Repository navigation
docs: issue a request in the HTTP interceptor test example - #71242
Open
mariella-203 wants to merge 1 commit into
Open
mariella-203 wants to merge 1 commit into
mariella-203 wants to merge 1 commit into
Conversation
Send and subscribe to the request before calling expectOne so the authentication interceptor runs. Flush the mock response after checking its header. Validate the original failure and corrected snippet for functional and DI interceptors with the main-branch HTTP testing backend. Check Markdown formatting and confirm the change is limited to one snippet.
hawkgs
reviewed
Oct 8, 2026
| const req = httpTesting.expectOne('/api/config'); | ||
|
|
||
| expect(req.request.headers.get('X-Authentication-Token')).toEqual(service.getAuthToken()); | ||
| req.flush({}); |
Member
There was a problem hiding this comment.
I would:
const service = TestBed.inject(AuthService);
// Make an HTTP request.
const response = firstValueFrom(http.get('/api/config'));
const req = httpTesting.expectOne('/api/config');
expect(req.request.headers.get('X-Authentication-Token')).toEqual(service.getAuthToken());in order to:
- Avoid the empty
.subscribe() - Drop the
req.flushto keep the example more concise since this is just a snippet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Send and subscribe to the request before calling
expectOneso the authentication interceptor runs.flushthe mock response after checking its header.Validate the original failure and corrected snippet for functional and DI interceptors with the main-branch HTTP testing backend.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information