Repository navigation
Conversation
…se classes When a bare class extends a component, the JIT compiler compiles it as an abstract directive. Previously, this caused the compiler to skip inheriting the component's metadata into the bare class due to an incorrect throw, or the bare class was skipped completely because `getDirectiveDef` looked up the prototype chain. This commit updates the `addDirectiveDefToUndecoratedParents` helper to use `Object.hasOwn` to ensure bare classes receive their own `ɵdir` containing their inputs/outputs, and updates `ɵɵInheritDefinitionFeature` to permit these abstract directives to inherit from components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a bare class extends a component, the JIT compiler compiles it as an abstract directive. Previously, this caused the compiler to skip inheriting the component's metadata into the bare class due to an incorrect throw, or the bare class was skipped completely because
getDirectiveDeflooked up the prototype chain.This PR updates the
addDirectiveDefToUndecoratedParentshelper to useObject.hasOwnto ensure bare classes receive their ownɵdircontaining their inputs/outputs, and updatesɵɵInheritDefinitionFeatureto permit these abstract directives to inherit from components.