Visitar URL original
refactor(schematics): remove unnecessary `compileComponents` by JeanMeche · Pull Request #33082 · angular/angular-cli · GitHub
Skip to content

refactor(schematics): remove unnecessary compileComponents #33082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JeanMeche wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(schematics): remove unnecessary compileComponents #33082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ages/angular/build/src/builders/unit-test/tests/behavior/coverage-ignore-comments_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ import { TestBed } from '@angular/core/testing';
import { AppComponent } from './app.component';

describe('AppComponent', () => {
beforeEach(async () => {
await TestBed.configureTestingModule({
beforeEach(() => {
TestBed.configureTestingModule({
imports: [AppComponent],
}).compileComponents();
});
});

it('should create the app', () => {
Expand Down
6 changes: 3 additions & 3 deletions .../schematics/angular/application/files/module-files/src/app/app__suffix__.spec.ts.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@ import { RouterModule } from '@angular/router';<% } %>
import { App } from './app<%= suffix %>';

describe('App', () => {
beforeEach(async () => {
await TestBed.configureTestingModule({<% if (routing) { %>
beforeEach(() => {
TestBed.configureTestingModule({<% if (routing) { %>
imports: [
RouterModule.forRoot([])
],<% } %>
declarations: [
App
],
}).compileComponents();
});
});

it('should create the app', () => {
Expand Down
6 changes: 0 additions & 6 deletions ...ematics/angular/application/files/standalone-files/src/app/app__suffix__.spec.ts.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,6 @@ import { TestBed } from '@angular/core/testing';
import { App } from './app<%= suffix %>';

describe('App', () => {
beforeEach(async () => {
await TestBed.configureTestingModule({
imports: [App],
}).compileComponents();
});

@cexbrayat cexbrayat Apr 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the call to configureTestingModule should be kept, even if empty, as it sets globally defined options like errorOnUnknownProperties IIRC

@JeanMeche JeanMeche Apr 29, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaik, there a fallbacks on options that aren't set. I personnaly rarely use it if I have no providers to override (in the context of standalone components).

@cexbrayat cexbrayat Apr 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a fallback, but it is only read when configureTestingModule() applies the TestBed options to the runtime strict-mode flags. createComponent() does not go through that path (at least it wasn't when I implemented it a few years ago, and I don't think it changed).

So if errorOnUnknownProperties is configured to true globally, as the CLI does by default, and the test does not call configureTestingModule(), unknown-property validation still uses the runtime default (false). Adding configureTestingModule() later, for example to override a provider, would then also start applying the global option and change the test behavior. This is the same for a handful of options.


it('should create the app', () => {
const fixture = TestBed.createComponent(App);
const app = fixture.componentInstance;
Expand Down
5 changes: 2 additions & 3 deletions ...t/files/__name@dasherize@if-flat__/__name@dasherize__.__type@dasherize__.spec.ts.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,9 @@ describe('<%= classifiedName %>', () => {
let fixture: ComponentFixture<<%= classifiedName %>>;

beforeEach(async () => {
await TestBed.configureTestingModule({
TestBed.configureTestingModule({
<%= standalone ? 'imports' : 'declarations' %>: [<%= classifiedName %>]
})
.compileComponents();
});

fixture = TestBed.createComponent(<%= classifiedName %>);
component = fixture.componentInstance;
Expand Down
8 changes: 0 additions & 8 deletions packages/schematics/angular/component/index_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,6 @@ describe('Component Schematic', () => {
appTree = await schematicRunner.runSchematic('application', appOptions, appTree);
});

it('should contain a TestBed compileComponents call', async () => {
const options = { ...defaultOptions };

const tree = await schematicRunner.runSchematic('component', options, appTree);
const tsContent = tree.readContent('/projects/bar/src/app/foo/foo.component.spec.ts');
expect(tsContent).toContain('compileComponents()');
});

it('should not set change detection when default is OnPush', async () => {
const options = { ...defaultOptions };

Expand Down
Loading