Visitar URL original
perf(@angular/build): reuse extendedConfigCache in TypeScript compilation by alan-agius4 · Pull Request #34192 · angular/angular-cli · GitHub
Skip to content

perf(@angular/build): reuse extendedConfigCache in TypeScript compilation - #34192

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:perf/cache-transformed-configuration
Oct 8, 2026
Merged

perf(@angular/build): reuse extendedConfigCache in TypeScript compilation#34192
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:perf/cache-transformed-configuration

Conversation

@alan-agius4

@alan-agius4 alan-agius4 commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Reusing TypeScript's extendedConfigCache across watch rebuilds eliminates redundant reading and re-parsing of extended tsconfig files from disk.

The referenced configuration files are also tracked so that entries in the cache are invalidated when those files change on disk.

See: angular/angular#71034

@angular-robot angular-robot Bot added area: performance Issues related to performance area: @angular/build labels Sep 28, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Sep 28, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a caching mechanism for the TypeScript configuration in the Angular build process to improve performance during watch mode rebuilds. The reviewer suggests enhancing this cache by tracking the 'rootFiles' to ensure the cache is properly invalidated when the set of root files changes, preventing potential compilation errors or stale configurations. All review comments are actionable and provide necessary improvements to the implementation.

Comment thread packages/angular/build/src/tools/angular/compilation/typescript-compilation.ts Outdated
Comment thread packages/angular/build/src/tools/angular/compilation/typescript-compilation.ts Outdated
Comment thread packages/angular/build/src/tools/angular/compilation/typescript-compilation.ts Outdated
Comment thread packages/angular/build/src/tools/angular/compilation/typescript-compilation.ts Outdated
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer requires: TGP This PR requires a passing TGP before merging is allowed freq2: medium target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release requires: TGP This PR requires a passing TGP before merging is allowed labels Sep 28, 2026
@alan-agius4
alan-agius4 requested a review from clydin September 28, 2026 17:42
@alan-agius4 alan-agius4 mentioned this pull request Sep 29, 2026
Merged
@alan-agius4
alan-agius4 force-pushed the perf/cache-transformed-configuration branch from 58616e8 to 440fe64 Compare September 29, 2026 07:45
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release and removed target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release labels Sep 30, 2026
@alan-agius4
alan-agius4 force-pushed the perf/cache-transformed-configuration branch from ba48b1a to 168aa51 Compare October 1, 2026 09:44
@alan-agius4
alan-agius4 force-pushed the perf/cache-transformed-configuration branch from 168aa51 to 2738cc3 Compare October 8, 2026 16:52
@alan-agius4
alan-agius4 removed the request for review from clydin October 8, 2026 17:32
@alan-agius4
perf(@angular/build): reuse extendedConfigCache in TypeScript compila…
5e38c6e 
…tion

Reusing TypeScript's extendedConfigCache across watch rebuilds eliminates redundant reading and re-parsing of extended tsconfig files from disk.

The referenced configuration files are also tracked so that entries in the cache are invalidated when those files change on disk.

See: angular/angular#71034
@alan-agius4
alan-agius4 force-pushed the perf/cache-transformed-configuration branch from 2738cc3 to 5e38c6e Compare October 8, 2026 17:37
@alan-agius4 alan-agius4 changed the title perf(@angular/build): cache transformed configuration in TypeScript compilation perf(@angular/build): reuse extendedConfigCache in TypeScript compilation Oct 8, 2026
@alan-agius4
alan-agius4 requested a review from dgp1130 October 8, 2026 17:40
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 8, 2026
@alan-agius4
alan-agius4 merged commit dcf906a into angular:main Oct 8, 2026
40 checks passed
@alan-agius4

alan-agius4 commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4
alan-agius4 deleted the perf/cache-transformed-configuration branch October 8, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgp1130 dgp1130 dgp1130 approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/build area: performance Issues related to performance target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alan-agius4 @dgp1130