Visitar URL original
fix(tui): list a child session when its exact ID is typed in the open menu by Tarquinen · Pull Request #62262 · anomalyco/opencode · GitHub
Skip to content

fix(tui): list a child session when its exact ID is typed in the open menu - #62262

Merged
Tarquinen merged 1 commit into
devfrom
open-child-session
Nov 7, 2026
Merged

fix(tui): list a child session when its exact ID is typed in the open menu#62262
Tarquinen merged 1 commit into
devfrom
open-child-session

Conversation

@Tarquinen

@Tarquinen Tarquinen commented Nov 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Issue for this PR

Closes #52069

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Pasting a subagent session ID into the open menu (ctrl+o) shows "No matches", so there's no way to jump to a child session by its ID. The session was found, then hidden by the filter that keeps child sessions out of the list. That filter now lets an exact ID match through. Child sessions still don't show up in the normal list. Same filter as #52086 by @kernel-oops.

How did you verify your code works?

In the real TUI, pressed ctrl+o and pasted a subagent session ID. Dev shows "No matches"; this branch lists the session. Extended the exact-ID test to cover it, and typecheck and tests pass.

Visual

<svg xmlns="http://www.w3.org/2000/svg" width="240" height="72" viewBox="0 0 240 72" fill="none">
  <style>
    .row { animation: show 4s ease-out infinite; }
    .caret { animation: blink 1s steps(1) infinite; }
    @keyframes show { 0%, 30% { opacity: 0; transform: translateY(4px); } 45%, 90% { opacity: 1; transform: translateY(0); } 100% { opacity: 0; } }
    @keyframes blink { 50% { opacity: 0; } }
    @media (prefers-reduced-motion: reduce) { .row, .caret { animation: none; } }
  </style>
  <rect x="8" y="6" width="224" height="60" rx="6" stroke="currentColor" stroke-opacity="0.3"/>
  <text x="18" y="24" font-family="monospace" font-size="10" fill="currentColor" fill-opacity="0.8">ses_e5272ade9ffe…</text>
  <rect class="caret" x="122" y="16" width="5" height="10" fill="currentColor" fill-opacity="0.6"/>
  <g class="row">
    <rect x="14" y="36" width="212" height="22" rx="4" fill="currentColor" fill-opacity="0.08"/>
    <text x="22" y="51" font-family="sans-serif" font-size="10" fill="currentColor">Explore billing (subagent)</text>
    <text x="218" y="51" font-family="sans-serif" font-size="9" text-anchor="end" fill="currentColor" fill-opacity="0.5">6h</text>
  </g>
</svg>

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

Added by the opencode bot (AI-generated).

Related: #60357

opencodejr[bot]
opencodejr Bot reviewed Nov 6, 2026
View reviewed changes

@opencodejr opencodejr Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix works. I reproduced #52069 on the base branch with the issue's drive script: typing the child session's ID in ctrl+o showed "No matches". With this change the child session is listed under Sessions, and pressing Enter goes to the session view. The updated dialog-open.test.tsx passes here (22 pass) and its child-ID case fails on the base branch. tsc -b in packages/tui passes.

The public API is unchanged; this is a TUI-only change.

The change only exempts the session matched by its exact ID, the same way the archived filter on the next line already does, and child sessions still stay out of the normal list. I have no concerns.

Related: #60357

Before

After

@Tarquinen
Tarquinen merged commit 4094ce1 into dev Nov 7, 2026
18 checks passed
@Tarquinen
Tarquinen deleted the open-child-session branch November 7, 2026 04:38
@github-actions github-actions Bot mentioned this pull request Nov 7, 2026
Open
autonull pushed a commit to autonull/opencode_spacegraph that referenced this pull request Nov 7, 2026
@Tarquinen me
fix(tui): list a child session when its exact ID is typed in the open…
dbab146 
… menu (anomalyco#62262)
@amrkmn amrkmn mentioned this pull request Nov 10, 2026
Closed
1 task
This was referenced Nov 10, 2026
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@opencodejr opencodejr[bot] opencodejr[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TUI (v2): typing a subagent's session ID in the open menu finds it, then doesn't list it

1 participant

@Tarquinen