Visitar URL original
fix(core): time out the Console config request after five seconds by rekram1-node · Pull Request #62404 · anomalyco/opencode · GitHub
Skip to content

fix(core): time out the Console config request after five seconds - #62404

Merged
rekram1-node merged 1 commit into
devfrom
console-fetch-timeout
Nov 6, 2026
Merged

fix(core): time out the Console config request after five seconds#62404
rekram1-node merged 1 commit into
devfrom
console-fetch-timeout

Conversation

@rekram1-node

@rekram1-node rekram1-node commented Nov 6, 2026 •
edited by opencodejr Bot
Loading

Copy link
Copy Markdown
Collaborator

Issue for this PR

Part of #57742.

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

The Console config request now times out after 5 seconds.

Before this, a Console that accepted the connection but never answered held the config load indefinitely. That includes the load when the OpenCode plugin activates at startup, so startup could hang for anyone with an opencode credential (Console login or Zen API key) on a network that black-holes the request. v2.2.5 behaves the same way. #61583 added this timeout, and its revert (#62397) removed it again.

A timeout counts as a transient failure, so SharedCache retries it 3 times with 1, 2 and 4 second backoff. A Console that never answers now costs at most about 27 seconds, after which the last config stays in effect. Background refreshes and account switches get the same bound.

How did you verify your code works?

  • New test in test/plugin/provider-opencode.test.ts: with a Console that accepts the request but never answers, plugin activation finishes after 4 attempts. It hangs without the change.
  • bun test test/plugin/provider-opencode.test.ts (packages/core): 52 pass
  • bun typecheck and bun run typecheck:tsc (packages/core): clean. oxlint and prettier on the changed files.

Visual

<svg xmlns="http://www.w3.org/2000/svg" width="240" height="72" viewBox="0 0 240 72" fill="none" stroke="currentColor" font-family="ui-monospace,monospace" font-size="9">
  <style>
    .b{transform-origin:16px 0;animation:b 3s linear infinite}
    @keyframes b{0%{transform:scaleX(0)}45%,100%{transform:scaleX(1)}}
    @media (prefers-reduced-motion:reduce){.b{animation:none}}
  </style>
  <text x="16" y="20" fill="currentColor" stroke="none" opacity=".7">Console config request</text>
  <rect x="16" y="32" width="208" height="12" rx="3" opacity=".25"/>
  <rect class="b" x="16" y="32" width="52" height="12" rx="3" fill="currentColor" stroke="none" opacity=".8"/>
  <path d="M68 28v20" stroke-width="2" stroke-linecap="round"/>
  <text x="58" y="62" fill="currentColor" stroke="none" opacity=".8">5s</text>
  <text x="204" y="62" fill="currentColor" stroke="none" opacity=".4">∞</text>
</svg>

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

Added by the opencode bot (AI-generated).

Related: #57742

exe.dev user
fix(core): time out the Console config request after five seconds
e0ed427 
A Console that accepted the connection but never answered held the config load
indefinitely, including the one at startup, so plugin activation could hang.
The request now times out after five seconds; SharedCache retries the timeout
as a transient failure and keeps the last config if every attempt fails.
opencodejr[bot]
opencodejr Bot reviewed Nov 6, 2026
View reviewed changes

@opencodejr opencodejr Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. I reproduced the hang on the base by running the new test there: plugin activation never finishes when the Console accepts the request and never answers. With this change, activation finishes after 4 attempts and the full provider-opencode test file passes (52/52). typecheck:tsc in packages/core is clean.

The timeout wraps the whole request, including reading the body, and SharedCache already retries timeouts as transient failures. So the worst case is the roughly 27 seconds you describe, after which the last config stays in effect.

The public API is unchanged.

No blocking concerns.

Related: #57742

@rekram1-node
rekram1-node merged commit 3346049 into dev Nov 6, 2026
16 checks passed
@rekram1-node
rekram1-node deleted the console-fetch-timeout branch November 6, 2026 18:44
@amrkmn amrkmn mentioned this pull request Nov 7, 2026
Closed
1 task
This was referenced Nov 7, 2026
Merged
Closed
autonull pushed a commit to autonull/opencode_spacegraph that referenced this pull request Nov 7, 2026
@rekram1-node exe.dev user me
fix(core): time out the Console config request after five seconds (an…
8aa551b 
…omalyco#62404)

Co-authored-by: exe.dev user <exedev@anton.exe.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@opencodejr opencodejr[bot] opencodejr[bot] left review comments

Assignees

No one assigned

Labels

contributor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rekram1-node