Repository navigation
Isolate persistence directories in durable subscription tests - #2638
Open
garydgregory wants to merge 1 commit into
Open
garydgregory wants to merge 1 commit into
garydgregory wants to merge 1 commit into
Conversation
DurableSubscriptionOfflineTestBase creates persistence adapters without assigning a broker-specific directory. KahaDB therefore uses its default shared directory, allowing concurrently running tests to contend for the same store lock. In CI, DurableSubscriptionOffline2Test spent about 50 seconds waiting for that lock after restarting its broker. Its 60-second timeout then expired while receiving messages. Set each adapter’s directory beneath the broker’s data directory, following the existing TestSupport pattern. This isolates test and parameter combinations while preserving stored messages across broker restarts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DurableSubscriptionOfflineTestBasecreates persistence adapters without assigning a broker-specific directory. KahaDB therefore uses its default shared directory, allowing concurrently running tests to contend for the same store lock.In CI,
DurableSubscriptionOffline2Testspent about 50 seconds waiting for that lock after restarting its broker. Its 60-second timeout then expired while receiving messages.Set each adapter’s directory beneath the broker’s data directory, following the existing TestSupport pattern. This isolates test and parameter combinations while preserving stored messages across broker restarts.