Visitar URL original
Upgrade importlib-resources version by bmckallagat-os · Pull Request #18209 · apache/airflow · GitHub
Skip to content

Upgrade importlib-resources version - #18209

Merged
kaxil merged 1 commit into
apache:mainfrom
pairity:main
Sep 13, 2021
Merged

Upgrade importlib-resources version#18209
kaxil merged 1 commit into
apache:mainfrom
pairity:main

Conversation

@bmckallagat-os

@bmckallagat-os bmckallagat-os commented Sep 13, 2021

Copy link
Copy Markdown
Contributor

Closes #18155

Update importlib-resources version as the current selected version is over a year old. Fixes compatibility issues with other packages.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg

boring-cyborg Bot commented Sep 13, 2021

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@bmckallagat-os

bmckallagat-os commented Sep 13, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

As a note, the following unittests failed which seem to be unrelated to this change:

FAILED tests/www/test_security.py::TestSecurity::test_verify_public_role_has_no_permissions - AssertionError: assert [can read on DAG:test_example_bash_operator] == []
FAILED tests/www/views/test_views_base.py::test_resetmypasswordview_edit[pk-admin] - AttributeError: 'NoneType' object has no attribute 'password'

I didn't want to patch them due to it being out of scope of this change, but just thought I would point it out. Everything else passed.

@bmckallagat-os

bmckallagat-os commented Sep 13, 2021

Copy link
Copy Markdown
Contributor Author

Not sure who to ping, but you commented on the ticket so @potiuk!

@bmckallagat-os

bmckallagat-os commented Sep 13, 2021

Copy link
Copy Markdown
Contributor Author

Checking the errors and will update accordingly.

@github-actions github-actions Bot added the full tests needed We need to run full set of tests for this PR to merge label Sep 13, 2021
@github-actions

github-actions Bot commented Sep 13, 2021

Copy link
Copy Markdown
Contributor

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@kaxil
kaxil merged commit 3b2b7e7 into apache:main Sep 13, 2021
@boring-cyborg

boring-cyborg Bot commented Sep 13, 2021

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request!

@kaxil kaxil added the type:improvement Changelog: Improvements label Sep 13, 2021
@jameslamb jameslamb mentioned this pull request Sep 13, 2021
Merged
kaxil pushed a commit that referenced this pull request Sep 13, 2021
@bmckallagat-os @bmckalla
Fix failing main due to #18209 (#18215)
b7f366c 
* Use mock in test_hooks mock import spec

* comment on mock

Co-authored-by: Braden McKallagat <braden.mckallagat@gmail.com>
@uranusjr uranusjr mentioned this pull request Sep 14, 2021
Closed
2 tasks done
@uranusjr

uranusjr commented Sep 14, 2021

Copy link
Copy Markdown
Member

This broke tests in main, see #18225.

@kaxil kaxil mentioned this pull request Sep 14, 2021
Merged
kaxil added a commit that referenced this pull request Sep 14, 2021
@kaxil
Revert Changes to importlib-resources (#18250)
c73004d 
Revert changes in #18209 and #18215 as it is causing issues and I merged that PR having missed that test was failing
@uranusjr uranusjr mentioned this pull request Sep 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaxil kaxil kaxil approved these changes

Assignees

No one assigned

Labels

full tests needed We need to run full set of tests for this PR to merge type:improvement Changelog: Improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade importlib-resources version

4 participants

@bmckallagat-os @uranusjr @kaxil @bmckalla