Repository navigation
GH-51696: [Python] Support float16 columns with NaN null kind in from_dataframe - #51716
Open
amanmaurya92 wants to merge 1 commit into
Open
amanmaurya92 wants to merge 1 commit into
amanmaurya92 wants to merge 1 commit into
Conversation
|
|
|
|
chrikrah
reviewed
Oct 11, 2026
chrikrah
left a comment
chrikrah
left a comment
There was a problem hiding this comment.
@amanmaurya92 measured at 334f08d: a pandas float16 column with NaN now imports as halffloat with a null, as reported in #51696, and the updated test fails on the old guard.
$ python -c 'import numpy as np, pandas as pd; from pyarrow.interchange import from_dataframe
print(from_dataframe(pd.DataFrame({"h": np.array([1.5, np.nan], dtype="<f2")}))["h"])'
# base e85e181: NotImplementedError: (<DtypeKind.FLOAT: 2>, 16, 'e', '=') with 1 is not yet supported.
# head 334f08d: [[1.5, null]]
$ python -m pytest -q pyarrow/tests/interchange/ # pyarrow 26.0.0 wheel, pandas 3.1.0rc0, CPython 3.12
# base e85e181: 3045 passed, 2 skipped
# head 334f08d: 3045 passed, 2 skipped
# head test, from_dataframe.py from e85e181: 1 failed, 3044 passed, 2 skipped
FAILED tests/interchange/test_conversion.py::test_pandas_to_pyarrow_float16_with_missing
# from_dataframe.py on main 5ef3c52 is unchanged since e85e181
Whether this lands, given the planned deprecation in #49629, is the maintainers' call and is already asked on #51696. If they want it kept, I can re-run the same check on a rebase onto main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
pa.interchange.from_dataframepreviously raisedNotImplementedErrorforfloat16columns withColumnNullType.USE_NANbecausepyarrow.compute.is_nanlacked a half-float kernel.Since GH-45083 added the
is_nanhalf-float kernel, this guard is no longer necessary.What changes are included in this PR?
float16NotImplementedErrorguard invalidity_buffer_nan_sentinel().test_pandas_to_pyarrow_float16_with_missinginpython/pyarrow/tests/interchange/test_conversion.pyto assert proper conversion topa.float16()with nulls.Are these changes tested?
Yes, tested via unit tests in
python/pyarrow/tests/interchange/test_conversion.py.Are there any user-facing changes?
Yes,
from_dataframenow successfully converts DataFrames containingfloat16columns with NaN nulls rather than raisingNotImplementedError.