Visitar URL original
Fix listTemplates NPE for External templates by DaanHoogland · Pull Request #14340 · apache/cloudstack · GitHub
Skip to content

Fix listTemplates NPE for External templates - #14340

Open
DaanHoogland wants to merge 1 commit into
4.22from
fix-npe-external-template-no-store
Open

DaanHoogland wants to merge 1 commit into
4.22from
fix-npe-external-template-no-store

Conversation

@DaanHoogland

Copy link
Copy Markdown
Contributor

Description

This PR...

fixes a NPE condition found during creating a new external hypervisor plugin.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov

codecov Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.05%. Comparing base (cdd03d7) to head (ed9571d).
⚠️ Report is 4 commits behind head on 4.22.

Files with missing lines Patch % Lines
...tack/storage/datastore/db/TemplateDataStoreVO.java 33.33% 2 Missing ⚠️
...a/com/cloud/api/query/dao/TemplateJoinDaoImpl.java 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #14340      +/-   ##
============================================
+ Coverage     18.02%   18.05%   +0.03%     
- Complexity    16247    16290      +43     
============================================
  Files          5936     5936              
  Lines        535778   537148    +1370     
  Branches      65608    66107     +499     
============================================
+ Hits          96556    96978     +422     
- Misses       428225   429163     +938     
- Partials      10997    11007      +10     
Flag Coverage Δ
uitests 4.04% <ø> (ø)
unittests 19.12% <60.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

sonarqubecloud Bot commented Oct 7, 2026

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant