Network ACL: validate the protocol name against the list, not as a substring - #14359

Description

createNetworkACL and updateNetworkACLItem accept protocol names that are not valid, such as cp, dp,ic or tcp,udp. The rule is stored and listed but never applied.

Fixes #14358

Why it breaks

NetworkACLServiceImpl.validateProtocol() checked a non-numeric protocol with supportedProtocolsForAclRules.contains(protocol.toLowerCase()). supportedProtocolsForAclRules is the string "tcp,udp,icmp,all", so this is a substring test: anything that appears inside it passes.

On the VR side, SetNetworkAclConfigItem doesn't recognise such a protocol, tries Integer.parseInt on it, and drops the rule with only a warning in the agent log. An allow or deny that the API accepted, and that the UI shows, silently does nothing.

How it is fixed

The protocol is compared against the entries of the list (split(",")), case-insensitively as before. The field, the error message and the valid names are unchanged.

How to reproduce the old behaviour

1. createNetworkACL aclid=<id> protocol=cp startport=22 endport=22 cidrlist=0.0.0.0/0 action=deny traffictype=ingress
   • Before: succeeds, and listNetworkACLs shows the rule with protocol cp. No rule for it appears on the VR, and the agent logs "Problem occurred when reading the entries in the ruleParts array".
   • After: Invalid protocol [cp]. Expected one of: [tcp,udp,icmp,all].

The old and new checks, side by side (jshell):

cp      -> old check passes: true, new: false
t       -> old check passes: true, new: false
dp,ic   -> old check passes: true, new: false
,       -> old check passes: true, new: false
tcp,udp -> old check passes: true, new: false

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

How Has This Been Tested?

• New NetworkACLServiceImplTest.validateProtocolTestProtocolIsPartOfTheSupportedList checks that cp, t, dp,ic, , and tcp,udp are each rejected.
• New validateProtocolTestProtocolNameInAnyCase checks that valid names are still accepted in any case (TCP, Udp, ICMP, All). The existing tests for valid names and protocol numbers still pass: NetworkACLServiceImplTest, 106 tests.
• server builds with checkstyle.

How did you try to break this feature and the system with this change?

• Valid input: every protocol name accepted today that is actually valid is still accepted, in any case. Numeric protocols take the other branch and are unaffected.
• Locale: the comparison now lowercases with Locale.ROOT. Under a Turkish default locale the old check rejected ICMP, because it lowercased to a dotless ıcmp; it is now accepted.
• Existing rules: a rule already stored with an invalid name would now fail validation on its next update. Such a rule has never been applied, so the error simply surfaces what was already broken.
• Other open PRs: this is independent of VPC ACL: keep the ports and ICMP type of rules given by protocol number or as upper-case ICMP #14357, which also touches NetworkACLServiceImpl, in a different method.