Visitar URL original
build: Cargo workspace + native-common extraction (1/6) by timsaucer · Pull Request #104 · apache/datafusion-java · GitHub
Skip to content

build: Cargo workspace + native-common extraction (1/6) #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andygrove merged 8 commits into from
Jun 13, 2026
Merged

build: Cargo workspace + native-common extraction (1/6) #104

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3cf0e81
build: consolidate Rust crates into a Cargo workspace + extract nativ…
timsaucer Jun 12, 2026
fd4dd74
build: inherit crate version/edition from workspace; publish datafusi…
timsaucer Jun 12, 2026
2e50d6e
build: drop forward-referencing RAT excludes from foundation split
timsaucer Jun 12, 2026
9d2096c
build: drop overbroad **/*.md RAT exclude
timsaucer Jun 12, 2026
2514f56
docs: add README for datafusion-jni-common
timsaucer Jun 12, 2026
3ff4fda
fix: scope foundation docs/excludes to what 1/6 ships
timsaucer Jun 12, 2026
bb023eb
build: point release scripts at workspace rust-target/ dir
timsaucer Jun 12, 2026
9e9de7d
build: mark datafusion-jni-common publish = false
timsaucer Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
build: inherit crate version/edition from workspace; publish datafusi… 
…on-jni-common

Add [workspace.package] (version, edition, license, repository) to the root
manifest and have both crates inherit it via `*.workspace = true`, so a single
bump re-versions the workspace in lock step.

Make datafusion-jni-common publishable: drop `publish = false` and add a
`description` (crates.io requires it). All its dependencies are registry
crates, so nothing blocks publish. datafusion-jni stays `publish = false`
since it is a JVM-loaded cdylib, not a crates.io library.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
  • Loading branch information
@timsaucer @claude
timsaucer and claude committed Jun 12, 2026
commit fd4dd74f3d8184a2002cd29131bc3d07fe9c525f
9 changes: 9 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,15 @@ members = [
"native-common",
]

# Shared package metadata so every crate moves in lock step. Members inherit
# via `version.workspace = true` / `edition.workspace = true` etc.; a single
# bump here re-versions the whole workspace.
[workspace.package]
version = "0.1.0"
edition = "2021"
license = "Apache-2.0"
repository = "https://github.com/apache/datafusion-java"

# Every dependency used by any workspace member is declared here so version
# bumps live in one place and the resolver picks a single version of each
# crate across the workspace. Members reference these via `{ workspace = true }`
Expand Down
8 changes: 5 additions & 3 deletions native-common/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,11 @@

[package]
name = "datafusion-jni-common"
version = "0.1.0"
edition = "2021"
publish = false
version.workspace = true
edition.workspace = true
license.workspace = true
repository.workspace = true
description = "Shared JNI plumbing for DataFusion Java native crates: error-to-exception mapping, the per-cdylib Tokio runtime singleton, and the async-stream-to-FFI_ArrowArrayStream bridge."

[features]
# `datafusion-jni` builds DataFusion with `avro`, which adds the
Expand Down
7 changes: 5 additions & 2 deletions native/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,11 @@

[package]
name = "datafusion-jni"
version = "0.1.0"
edition = "2021"
version.workspace = true
edition.workspace = true
license.workspace = true
repository.workspace = true
# cdylib JNI artifact loaded by the JVM, not a crates.io library.
publish = false

[lib]
Expand Down