Visitar URL original
Run the tests that have no @Test by sharanggupta · Pull Request #16527 · apache/dubbo · GitHub
Skip to content

Run the tests that have no @Test - #16527

Merged
RainYuY merged 3 commits into
apache:3.3from
sharanggupta:run-tests-missing-annotation
Oct 21, 2026
Merged

Run the tests that have no @Test#16527
RainYuY merged 3 commits into
apache:3.3from
sharanggupta:run-tests-missing-annotation

Conversation

@sharanggupta

@sharanggupta sharanggupta commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What is the purpose of the change?

Three test methods have no @Test, so they never run:

  • ParametersTest.testMap2Parameters and testString2Parameters: the class extended JUnit 3's TestCase until the upgrade to JUnit 5 in Upgrade junt to junit5 #3149, which removed extends TestCase without adding @Test. The class has had no test since.
  • RegistryConfigTest.testPreferredWithTrueValue: its counterpart testPreferredWithFalseValue right below it has @Test, but this one does not.

This adds @Test to the three methods, and removes their public modifier like the other test methods (#10977, #10978). They pass.

Checklist

  • Make sure there is a GitHub_issue field for the change. (No issue; this only changes tests.)
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@sharanggupta
Run the tests that have no @test
495b5e6 
ParametersTest lost its test runner when the JUnit 5 migration removed
"extends TestCase", and RegistryConfigTest.testPreferredWithTrueValue
never had @test, unlike testPreferredWithFalseValue. Annotate them so
they run.
@sharanggupta
Remove ParametersTest.testMap2Parameters
102a23d 
It only put values into a HashMap and read them back, so it tested no
Dubbo code.
@codecov-commenter

codecov-commenter commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.90%. Comparing base (b73b9d1) to head (e021642).
⚠️ Report is 2 commits behind head on 3.3.

Additional details and impacted files 
@@             Coverage Diff              @@
##                3.3   #16527      +/-   ##
============================================
  Coverage     60.89%   60.90%              
+ Complexity    11753       15   -11738     
============================================
  Files          1953     1953              
  Lines         89278    89280       +2     
  Branches      13475    13476       +1     
============================================
+ Hits          54367    54372       +5     
+ Misses        29329    29321       -8     
- Partials       5582     5587       +5
Flag Coverage Δ
integration-tests-java21 32.08% <ø> (+<0.01%) ⬆️
integration-tests-java8 32.15% <ø> (-0.04%) ⬇️
samples-tests-java21 32.13% <ø> (-0.01%) ⬇️
samples-tests-java8 29.80% <ø> (+0.04%) ⬆️
unit-tests-java11 59.16% <ø> (+0.03%) ⬆️
unit-tests-java17 58.59% <ø> (-0.01%) ⬇️
unit-tests-java21 58.61% <ø> (-0.01%) ⬇️
unit-tests-java25 58.57% <ø> (+<0.01%) ⬆️
unit-tests-java8 59.12% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

RainYuY
RainYuY requested changes Oct 20, 2026
View reviewed changes

@RainYuY RainYuY left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t remove this existing test.

Comment thread dubbo-common/src/test/java/org/apache/dubbo/common/utils/ParametersTest.java
final String ServiceVersion = "1.0.15";
final String LoadBalance = "lcr";

public void testMap2Parameters() {

@RainYuY RainYuY Oct 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why

@sharanggupta sharanggupta Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it because it only reads back the values it puts into the HashMap itself, but you're right, that's not for this PR to decide. It's back in e021642, with @Test so that it runs.

@sharanggupta
Keep ParametersTest.testMap2Parameters
e021642 
Restore the test, with @test so that it runs, as requested in review.
@RainYuY
RainYuY merged commit 843b98b into apache:3.3 Oct 21, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RainYuY RainYuY RainYuY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sharanggupta @codecov-commenter @RainYuY