Repository navigation
Conversation
Add column-backed parity coverage for Spark SQL shiftrightunsigned and the unsigned right-shift operator across integer, bigint, boundary, and null inputs. Mark both forms supported by the Velox backend. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 309a2429-55f4-46e7-9229-4c2be58b1598
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Add Velox-backend coverage for Spark SQL
shiftrightunsigned:shiftrightunsigned(value, shift)and the>>>operator.Gluten already maps Spark's
ShiftRightUnsignedexpression to the nativeshiftrightunsignedfunction, so no additional expression-conversion code is required.This change depends on the companion Velox implementation in facebookincubator/velox#19376 being included in Gluten's pinned Velox dependency before merge.
How was this patch tested?
ProjectExecTransformerexecution../dev/format-scala-code.sh checkgit diff --checkNative builds and test binaries were not run locally because the currently pinned Velox dependency does not yet contain the companion implementation. The draft PR is intended to use CI after the Velox dependency is updated.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: GitHub Copilot CLI 1.0.89 (GPT-5.6 Sol)