Visitar URL original
HBASE-30409 Move throttle enabled flag storage from zookeeper to mast… by Apache9 · Pull Request #8705 · apache/hbase · GitHub
Skip to content

HBASE-30409 Move throttle enabled flag storage from zookeeper to mast… - #8705

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-30409
Oct 11, 2026
Merged

HBASE-30409 Move throttle enabled flag storage from zookeeper to mast…#8705
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-30409

Conversation

@Apache9

@Apache9 Apache9 commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

…er local region

@Apache9 Apache9 self-assigned this Sep 27, 2026
@Apache9

Apache9 commented Sep 28, 2026

Copy link
Copy Markdown
Contributor Author

The intention for this PR is to reduce zk deoendencies in HBase.

Also fixed bugs in SwitchRpcThrottleProcedure.
We can not store any non serializable field in procedure because when master restarts, we need to reload the procedure, non serializable field can not be store/reload. We should get it from MasterProcedureEnv.
And also, the procedure should implement GlobalProcedureInterface, instead of ServerProcedureInterface.

charlesconnell
charlesconnell reviewed Sep 30, 2026
View reviewed changes
Comment thread hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java Outdated
import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos.TruncateTableResponse;
import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos.UnassignRegionRequest;
import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos.UnassignRegionResponse;
import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos.*;

@charlesconnell charlesconnell Sep 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to insert the wildcard import?

@Apache9 Apache9 Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the IDE did this automatically. Let me revert.

charlesconnell
charlesconnell reviewed Oct 8, 2026
View reviewed changes
Comment thread hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/RpcThrottleStateStore.java
Comment on lines +45 to +48
public RpcThrottleStateStore(MasterRegion masterRegion, ZKWatcher watcher, String zkPath)
throws IOException, KeeperException, DeserializationException {
super(masterRegion, STATE_NAME, watcher, zkPath);
}

@charlesconnell charlesconnell Oct 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to keep the Zookeeper plumbing if it's not desired to use it?

@Apache9 Apache9 Oct 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for migrating as the old data is already stored on zookeeper.

You can see the logic in the base class MasterStateStore.

@charlesconnell charlesconnell Oct 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood

@Apache9
Apache9 merged commit 9b00e9c into apache:master Oct 11, 2026
8 checks passed
Apache9 added a commit that referenced this pull request Oct 11, 2026
@Apache9
HBASE-30409 Move throttle enabled flag storage from zookeeper to mast…
80c0e46 
…er local region (#8705)

Signed-off-by: Charles Connell <cconnell@apache.org>
(cherry picked from commit 9b00e9c)
Apache9 added a commit that referenced this pull request Oct 11, 2026
@Apache9
HBASE-30409 Move throttle enabled flag storage from zookeeper to mast…
602e999 
…er local region (#8705)

Signed-off-by: Charles Connell <cconnell@apache.org>
(cherry picked from commit 9b00e9c)
@Apache9 Apache9 mentioned this pull request Oct 11, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charlesconnell charlesconnell charlesconnell approved these changes
@rmdmattingly rmdmattingly Awaiting requested review from rmdmattingly
@liuxiaocs7 liuxiaocs7 Awaiting requested review from liuxiaocs7

Assignees

@Apache9 Apache9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Apache9 @charlesconnell