Visitar URL original
[doc] add Redis Sentinel and Apache Kvrocks monitoring help documentation by SatyamPandey-07 · Pull Request #4371 · apache/hertzbeat · GitHub
Skip to content

[doc] add Redis Sentinel and Apache Kvrocks monitoring help documentation - #4371

Open
SatyamPandey-07 wants to merge 5 commits into
apache:masterfrom
SatyamPandey-07:doc-cache-monitoring-help
Open

SatyamPandey-07 wants to merge 5 commits into
apache:masterfrom
SatyamPandey-07:doc-cache-monitoring-help

Conversation

@SatyamPandey-07

Copy link
Copy Markdown

What's changed?

  • Added user help documentation for Redis Sentinel monitoring in both English (home/docs/help/redis_sentinel.md) and Chinese (home/i18n/zh-cn/docusaurus-plugin-content-docs/current/help/redis_sentinel.md), detailing configuration parameters, SSH tunnel parameters, and metrics sets (server, clients, stats, cpu, sentinel).
  • Added user help documentation for Apache Kvrocks monitoring in both English (home/docs/help/kvrocks.md) and Chinese (home/i18n/zh-cn/docusaurus-plugin-content-docs/current/help/kvrocks.md), detailing configuration parameters and metrics sets (server, clients, memory, persistence, stats, replication, cpu, cluster, commandstats, keyspace).
  • Updated home/sidebars.json under the cache category to register help/redis_sentinel and help/kvrocks, eliminating 404 links from the monitoring console help buttons.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

fixes #4370

@github-actions github-actions Bot added the doc Improvements or additions to documentation label Sep 7, 2026
@zqr10159

Copy link
Copy Markdown
Member

Thanks for adding the missing help pages. I checked the Sentinel parameter table against app-redis_sentinel.yml and RedisCommonCollectImpl. Please correct these in both the English and Chinese pages:

  1. Line 19 describes Pattern as an optional regular expression for filtering INFO output. The template defines a required numeric mode with default 2, and the collector uses it to choose the connection mode, not as a regex filter. Please describe it as the internal Sentinel mode/default, or omit it from the user-facing parameter table since it is hidden.
  2. Line 23 lists the SSH timeout default as 60000 ms, but the template sets sshTimeout to 6000 ms. Please align the documentation with that default.

After updating, please validate the documentation build and the English/Chinese help links. DOC CI and the license workflow are currently awaiting maintainer approval, so there is no CI build result yet. These findings are from source comparison; I have not run the site locally.

@SatyamPandey-07

Copy link
Copy Markdown
Author

Hi @zqr10159, thanks for the thorough review!

I have updated both the English and Chinese documentation pages:

  1. Pattern parameter: Omitted Pattern from the user-facing configuration table in both docs since it is an internal mode parameter defined as hide: true with a default of 2.
  2. SSH Timeout: Aligned SSH Timeout(ms) default to 6000ms (and 6000 毫秒 in Chinese) to match sshTimeout in app-redis_sentinel.yml.

Local Validation

  • Filename check: python ./script/ci/docs/check_file_name.py ./script/ci/docs/check_file_name.json → Passed.
  • Markdown lint: pnpm run md-lint → Passed (571 files checked, 0 errors).
  • Site build: Ran pnpm run build locally → Built successfully for all locales (en, zh-cn, ko) with no broken links or markdown link errors.
  • Help routes: Verified /docs/help/redis_sentinel and /docs/help/kvrocks routes match the helpLink values in app-redis_sentinel.yml and app-kvrocks.yml.

Please take another look when you have a moment. Thanks!

@zqr10159

zqr10159 commented Oct 1, 2026

Copy link
Copy Markdown
Member

Thanks for the update. I rechecked 202ab98: Pattern is omitted and the SSH timeout is 6000 ms in both the English and Chinese Sentinel pages. Those two points are fixed.

There is still a P2 concern with the help routes. In home/docusaurus.config.js, lastVersion is '1.8.0' and current only overrides the label, not the path:

lastVersion: '1.8.0',
versions: {
current: {
label: 'current',
},
},

With Docusaurus's version routing, this puts current docs under /docs/next/, while /docs/ belongs to 1.8.0. This PR adds the pages only to home/docs and the Chinese current directory; neither 1.8.0 help directory contains redis_sentinel.md or kvrocks.md, and the PR adds no redirects for them. The templates still point to the unversioned URLs. Based on the source, I would therefore expect the new pages at /docs/next/help/{redis_sentinel,kvrocks} and /zh-cn/docs/next/help/{redis_sentinel,kvrocks}, rather than the console's existing destinations.

Could you please serve the production build and check these four exact helpLink URLs, confirming that each renders the intended help page rather than a 404?

For local validation, replace only the origin with the local server address and keep those paths unchanged. A successful docs build alone may not catch URLs supplied by the application YAML. If the mismatch is confirmed, please add the pages to the default version, provide redirects, or align the helpLink values with the generated routes.

This is a source-based finding; I have not independently built or served the site.

@SatyamPandey-07

Copy link
Copy Markdown
Author

Hi @zqr10159, good catch! Thank you for pointing out the Docusaurus version routing behavior with lastVersion: '1.8.0'.

You were completely right: because 1.8.0 is the default release version mapped to /docs/ and current maps to /docs/next/, adding the pages only under current resulted in the unversioned console URLs 404ing.

To align with how versioned docs and sidebars are maintained across the project (similar to PR #4113 and #4112):

  1. Added redis_sentinel.md and kvrocks.md to home/versioned_docs/version-1.8.0/help/ (English).
  2. Added redis_sentinel.md and kvrocks.md to home/i18n/zh-cn/docusaurus-plugin-content-docs/version-1.8.0/help/ (Chinese).
  3. Registered both entries under the cache category in home/versioned_sidebars/version-1.8.0-sidebars.json.

Local Validation

  • Filename check: python ./script/ci/docs/check_file_name.py ./script/ci/docs/check_file_name.json -> Passed.
  • Markdown lint: pnpm run md-lint -> Passed (571 files checked, 0 errors).
  • Production build: pnpm run build -> Completed successfully for all locales (en, zh-cn, ko).
  • Route check with pnpm run serve: Served the production build and verified that all 4 exact URLs return 200 OK and render the intended pages:
    • http://localhost:3000/docs/help/redis_sentinel (200 OK)
    • http://localhost:3000/zh-cn/docs/help/redis_sentinel (200 OK)
    • http://localhost:3000/docs/help/kvrocks (200 OK)
    • http://localhost:3000/zh-cn/docs/help/kvrocks (200 OK)

Please take another look when you have a moment. Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task] Add user help documentation for Redis Sentinel and Apache Kvrocks monitoring

3 participants