Repository navigation
[doc] add Redis Sentinel and Apache Kvrocks monitoring help documentation - #4371
SatyamPandey-07 wants to merge 5 commits into
Conversation
|
Thanks for adding the missing help pages. I checked the Sentinel parameter table against app-redis_sentinel.yml and RedisCommonCollectImpl. Please correct these in both the English and Chinese pages:
After updating, please validate the documentation build and the English/Chinese help links. DOC CI and the license workflow are currently awaiting maintainer approval, so there is no CI build result yet. These findings are from source comparison; I have not run the site locally. |
|
Hi @zqr10159, thanks for the thorough review! I have updated both the English and Chinese documentation pages:
Local Validation
Please take another look when you have a moment. Thanks! |
|
Thanks for the update. I rechecked 202ab98: Pattern is omitted and the SSH timeout is 6000 ms in both the English and Chinese Sentinel pages. Those two points are fixed. There is still a P2 concern with the help routes. In home/docusaurus.config.js, lastVersion is '1.8.0' and current only overrides the label, not the path: hertzbeat/home/docusaurus.config.js Lines 330 to 335 in 202ab98 With Docusaurus's version routing, this puts current docs under /docs/next/, while /docs/ belongs to 1.8.0. This PR adds the pages only to home/docs and the Chinese current directory; neither 1.8.0 help directory contains redis_sentinel.md or kvrocks.md, and the PR adds no redirects for them. The templates still point to the unversioned URLs. Based on the source, I would therefore expect the new pages at /docs/next/help/{redis_sentinel,kvrocks} and /zh-cn/docs/next/help/{redis_sentinel,kvrocks}, rather than the console's existing destinations. Could you please serve the production build and check these four exact helpLink URLs, confirming that each renders the intended help page rather than a 404?
For local validation, replace only the origin with the local server address and keep those paths unchanged. A successful docs build alone may not catch URLs supplied by the application YAML. If the mismatch is confirmed, please add the pages to the default version, provide redirects, or align the helpLink values with the generated routes. This is a source-based finding; I have not independently built or served the site. |
|
Hi @zqr10159, good catch! Thank you for pointing out the Docusaurus version routing behavior with You were completely right: because To align with how versioned docs and sidebars are maintained across the project (similar to PR #4113 and #4112):
Local Validation
Please take another look when you have a moment. Thanks! |
What's changed?
home/docs/help/redis_sentinel.md) and Chinese (home/i18n/zh-cn/docusaurus-plugin-content-docs/current/help/redis_sentinel.md), detailing configuration parameters, SSH tunnel parameters, and metrics sets (server,clients,stats,cpu,sentinel).home/docs/help/kvrocks.md) and Chinese (home/i18n/zh-cn/docusaurus-plugin-content-docs/current/help/kvrocks.md), detailing configuration parameters and metrics sets (server,clients,memory,persistence,stats,replication,cpu,cluster,commandstats,keyspace).home/sidebars.jsonunder thecachecategory to registerhelp/redis_sentinelandhelp/kvrocks, eliminating 404 links from the monitoring console help buttons.Checklist
Add or update API
fixes #4370