Repository navigation
Conversation
Spark treats maxResultSize=0 as unlimited, so do not force local manifest planning for that setting. Generated-by: Codex
gerashegalov
reviewed
Oct 9, 2026
gerashegalov
left a comment
gerashegalov
left a comment
Contributor
There was a problem hiding this comment.
LGTM
the practice is to start with the highest Spark shim PR followed up with backports once the first PR is merged. Consider submitting 4.2 fix first
Author
|
@gerashegalov can do. I haven't checked this on 4.2 but will add it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spark treats
spark.driver.maxResultSize=0as unlimited, but Iceberg's 256 MiB planning check treats it as too small and forces local manifest planning. Allow distributed planning for zero while keeping the local path for positive limits below the threshold.Test plan: Verify data and delete planning with zero, 128 MiB, and 256 MiB limits. The focused Spark 3.5 tests, formatting, checkstyle, and module build passed.
AI Disclosure