Repository navigation
Conversation
slbotbm
marked this pull request as draft
October 4, 2026 10:23
github-actions
Bot
added
S-waiting-on-review
Contributor
Author
|
#3995 is a blocker for this. If author does not respond in some days, I'll drive that PR to completion |
Contributor
|
since purge is going away (removal pr goes up today), no need to port the purge tests in |
slbotbm
force-pushed
the
cpp-high-level-client-4
branch
from
October 8, 2026 16:31
acbe063 to
6a13dca
Compare
Frees the name for the consumer a poll names, matching the Rust SDK.
The kind was a string, so a bad one only failed once it reached Rust.
Building the bridge struct by hand leaves the kind unset and the partition sentinel unnamed.
The kind is now checked where the call is written. BREAKING CHANGE: poll_messages, store_consumer_offset, get_consumer_offset and delete_consumer_offset replace their consumer_kind and consumer_id arguments with a single consumer.
Two names read the whole partition, one shared name does not, and a group member reads its assignment rather than partition 0.
Clears the TODO left for them, now that consumer groups exist.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4397 +/- ##
==========================================
Coverage 87.82% 87.82%
Complexity 1607 1607
==========================================
Files 1302 1302
Lines 252088 252231 +143
Branches 212381 212436 +55
==========================================
+ Hits 221394 221524 +130
+ Misses 25408 25376 -32
- Partials 5286 5331 +45
🚀 New features to boost your workflow:
|
Contributor
Author
|
removed purge apis in this pr |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
Closes #
Relates to #2100
Rationale
Expose the final set of functions offered by cpp bridge in the high level client
What changed?
Added the following functions and their related data structs:
Also translated tests to use high level client, deleting those that tested bridge code and were not possible to test in the high level client.
Local Execution
AI Usage
If AI tools were used, please answer: