Repository navigation
Conversation
The pre-rebuild deletion treated any JS file under 10 lines as minified, so actions with no build step lost small hand-written modules (manusa/actions-setup-minikube's 8-line src/shell-quote.js) and failed with "only in original". Minified now means long lines: average >500 chars, or a line >500 chars in a file under 10 lines. The registry check also flagged vendored package.json files carrying npm v6's "bundleDependencies": false / "deprecated": false; both are now dropped when exactly false. Seen on #1323. Generated-by: Claude Opus 5
Member
Author
|
Gentle ping @dfoulks1 @ppkarwasz - this has been waiting for review for a while; CI is green. A quick look would be appreciated. Drafted-by: Claude Code (Opus 5.5); reviewed by @potiuk before posting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diff_js.is_minified()(now module-level).normalize_package_jsondrops npm v6's"bundleDependencies": false/"deprecated": false(only when exactlyfalse).Why: #1323 (
manusa/actions-setup-minikubev2.19.0, no build step) failedverifybecause its hand-written 8-linesrc/shell-quote.jswas deleted before the rebuild and never recreated, and its vendoredtunnel/package.jsonstill carried npm v6 placeholders.Test plan
shell-quote.js,sha256-hex.js,tunnel/package.json).shand checks it agrees withis_minified().uv run pytest utils/tests/— 368 passed;prek run --all-filesclean.🤖 Generated with Claude Code