Repository navigation
MINOR: Add tests that tagged fields are written in ascending tag order - #23717
Open
gabriellefu wants to merge 2 commits into
Open
gabriellefu wants to merge 2 commits into
gabriellefu wants to merge 2 commits into
Conversation
github-actions
Bot
added
triage
shayelkin
reviewed
Oct 5, 2026
shayelkin
left a comment
shayelkin
left a comment
Contributor
There was a problem hiding this comment.
I don't think this tests what we expect: it verifies that the tags are written in the order they are added, which is not the same as ascending tag order.
The right properties to validate are:
- The tags are indeed in the expected order, which can be checked multiple ways. For example, that or every two consecutive tags
t1, t2in the message,t1 < t2, or that sorting the tags keeps their order the same, and there are no duplicates. - And that all tags in expectedTags were written to the message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests that tagged fields are written in ascending tag order