Visitar URL original
Restore compatibility in maven-embedder by gnodet · Pull Request #11320 · apache/maven · GitHub
Skip to content

Restore compatibility in maven-embedder - #11320

Merged
gnodet merged 6 commits into
apache:masterfrom
gnodet:copilot/fix-missing-code-restoration
Oct 27, 2025
Merged

gnodet merged 6 commits into
apache:masterfrom
gnodet:copilot/fix-missing-code-restoration

Conversation

@gnodet

@gnodet gnodet commented Oct 23, 2025 •

Copy link
Copy Markdown
Contributor

Add missing deprecated constants and classes for backward compatibility in maven-embedder.

Fixes #11300

@gnodet

gnodet commented Oct 23, 2025

Copy link
Copy Markdown
Contributor Author

@laeubi will that fix all your compatibility problems ?

@gnodet
gnodet marked this pull request as ready for review October 23, 2025 19:19

@laeubi laeubi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me thanks!

Copilot AI and others added 4 commits October 26, 2025 21:38
Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
- Created org.apache.maven.cli.internal.extension.model package
- Added CoreExtension and CoreExtensions classes (deprecated)
- Updated ExtensionResolutionException to return old model type
- Added overloaded constructor for compatibility with new API

Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
@gnodet
gnodet force-pushed the copilot/fix-missing-code-restoration branch from c525ab3 to ff3bc7b Compare October 26, 2025 20:38
@gnodet
gnodet requested a review from cstamas October 27, 2025 09:11
@gnodet
gnodet merged commit 9a5fb67 into apache:master Oct 27, 2025
@github-actions github-actions Bot added this to the 4.1.0 milestone Oct 27, 2025
gnodet added a commit to gnodet/maven that referenced this pull request Oct 27, 2025
* Initial plan

* Add missing deprecated constants to MavenCli for backward compatibility

Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>

* Add missing extension model classes for backward compatibility

- Created org.apache.maven.cli.internal.extension.model package
- Added CoreExtension and CoreExtensions classes (deprecated)
- Updated ExtensionResolutionException to return old model type
- Added overloaded constructor for compatibility with new API

Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>

* Add missing xpp3 reader/writer

* Do not add @deprecated on constants since the class already is

* Add two other missing constants

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
(cherry picked from commit 9a5fb67)
@gnodet

gnodet commented Oct 27, 2025

Copy link
Copy Markdown
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ maven-4.0.x

Questions ?

Please refer to the Backport tool documentation

gnodet added a commit that referenced this pull request Oct 27, 2025
* Initial plan

* Add missing deprecated constants to MavenCli for backward compatibility

* Add missing extension model classes for backward compatibility

- Created org.apache.maven.cli.internal.extension.model package
- Added CoreExtension and CoreExtensions classes (deprecated)
- Updated ExtensionResolutionException to return old model type
- Added overloaded constructor for compatibility with new API

* Add missing xpp3 reader/writer

* Do not add @deprecated on constants since the class already is

* Add two other missing constants

---------

(cherry picked from commit 9a5fb67)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
@gnodet
gnodet deleted the copilot/fix-missing-code-restoration branch October 26, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[back compat] some constants and code is missing from maven-embedder

4 participants