Repository navigation
Conversation
The entries for ingress-nginx, Kubegres, openshift-acme, Prometheus and kube-state-metrics, and the OpenWhisk Helm chart descriptors named only the copies under oplugins. The source release also ships copies under oplugins-op and testing; list those paths too, including the ingress-nginx controller versions they carry (v1.8.1, v1.5.1). Part of apache#260. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The NOTICE entries for ingress-nginx, Kubegres, openshift-acme and Prometheus / kube-state-metrics said the files were "under oplugins". The previous commit listed the copies under oplugins-op and testing in LICENSE; say the same in NOTICE so the two files agree. Part of apache#260. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
pjfanning
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #260.
The top-level
LICENSEcredits ingress-nginx, Kubegres, openshift-acme, Prometheus / kube-state-metrics and the OpenWhisk Helm chart, but each entry names only the copies underoplugins/. The source release (checked againstapache-openserverless-0.9.0-incubating-src.tar.gz, RC7) also ships copies of the same components underoplugins-op/andtesting/. This PR adds those paths to the existing entries:oplugins-op/deploy/ingress-nginx/(controller v1.8.1 and v1.5.1, versions LICENSE did not mention) andtesting/stress-test/oplugins-stress/setup/docker/ingress-deploy.yaml(v1.7.0). The entry is now grouped by controller version.oplugins-op/deploy/openserverless-permissions/andtesting/stress-test/oplugins-stress/setup/kubernetes/, plus the operator deploymentoplugins-op/deploy/postgres-operator/kubegres-operator.yaml(Kubegres 1.18).oplugins-op/deploy/acme-openshift/.oplugins-op/deploy/monitoring/*and the monitoring service accounts / roles inoplugins-op/deploy/openserverless-permissions/.oplugins-op/andtesting/that carry# Source: openwhisk/templates/...comments.Some of this was already highlighted in #250 (found while verifying RC5), which listed the ingress-nginx and Kubegres copies under
oplugins-op/andtesting/among the vendored manifests missing fromLICENSE. That PR was closed pending a clean-up of obsolete dependencies; these files are still in the RC7 source release, so they still need to be attributed. This PR is narrower: it only extends the entriesLICENSEalready has.NOTICEis updated to match: its entries for ingress-nginx, Kubegres, openshift-acme and Prometheus / kube-state-metrics said the files were "under oplugins", and now nameoplugins-opandtestingtoo, where applicable.Every path listed exists in the RC7 source tarball. LICENSE and NOTICE only; no code changes.
Not covered here: components missing from LICENSE entirely (mvdan/sh, Milvus, milvus-operator and Locust in #260; Kvrocks in #262; cert-manager in #263), and the ASF headers on vendored third-party files (#260).
🤖 Generated with Claude Code