Visitar URL original
Sort Splunk logs by timestamp by selfxp · Pull Request #5057 · apache/openwhisk · GitHub
Skip to content

Sort Splunk logs by timestamp - #5057

Open
selfxp wants to merge 1 commit into
apache:masterfrom
selfxp:stanciu/sort-splunk-logs
Open

Sort Splunk logs by timestamp#5057
selfxp wants to merge 1 commit into
apache:masterfrom
selfxp:stanciu/sort-splunk-logs

Conversation

@selfxp

@selfxp selfxp commented Jan 30, 2021

Copy link
Copy Markdown
Contributor

Fixes an issue that was noticed when pulling logs from Splunk where logs were coming in unexpected order.
This PR will force logs to be sorted by timestamp first and then returned in a reverse order.

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@selfxp
selfxp requested review from mcdan and tysonnorris January 30, 2021 00:55
mcdan
mcdan reviewed Jan 30, 2021
View reviewed changes
Comment thread ...on/scala/src/main/scala/org/apache/openwhisk/core/containerpool/logging/SplunkLogStore.scala
@codecov-io

codecov-io commented Jan 30, 2021

Copy link
Copy Markdown

Codecov Report

Merging #5057 (2854f93) into master (efdbd60) will increase coverage by 36.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5057       +/-   ##
===========================================
+ Coverage   34.77%   71.09%   +36.31%     
===========================================
  Files         200      200               
  Lines        9759     9759               
  Branches      441      441               
===========================================
+ Hits         3394     6938     +3544     
+ Misses       6365     2821     -3544
Impacted Files Coverage Δ
...sk/core/containerpool/logging/SplunkLogStore.scala 85.18% <100.00%> (+85.18%) ⬆️
...che/openwhisk/core/invoker/LogStoreCollector.scala 0.00% <0.00%> (-100.00%) ⬇️
...a/org/apache/openwhisk/http/BasicHttpService.scala 3.33% <0.00%> (-86.67%) ⬇️
...la/org/apache/openwhisk/http/BasicRasService.scala 16.66% <0.00%> (-83.34%) ⬇️
...scheduler/queue/ElasticSearchDurationChecker.scala 0.00% <0.00%> (-78.85%) ⬇️
...la/org/apache/openwhisk/core/invoker/Invoker.scala 1.58% <0.00%> (-68.26%) ⬇️
...pache/openwhisk/core/invoker/InvokerReactive.scala 0.00% <0.00%> (-60.00%) ⬇️
...apache/openwhisk/core/ack/MessagingActiveAck.scala 0.00% <0.00%> (-54.55%) ⬇️
...whisk/connector/kafka/KafkaMessagingProvider.scala 29.26% <0.00%> (-41.47%) ⬇️
...tainerpool/docker/DockerClientWithFileAccess.scala 56.00% <0.00%> (-36.00%) ⬇️
... and 136 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efdbd60...2854f93. Read the comment docs.

@mcdan
mcdan self-requested a review February 1, 2021 14:15
@style95

style95 commented Jan 25, 2023

Copy link
Copy Markdown
Member

@mcdan Would it be ok to merge this PR?

@codecov-commenter

codecov-commenter commented Jul 24, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.23%. Comparing base (efdbd60) to head (2854f93).
⚠️ Report is 258 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (efdbd60) and HEAD (2854f93). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (efdbd60) HEAD (2854f93)
6 3
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5057      +/-   ##
==========================================
- Coverage   82.50%   75.23%   -7.27%     
==========================================
  Files         207      200       -7     
  Lines       10024     9759     -265     
  Branches      444      441       -3     
==========================================
- Hits         8270     7342     -928     
- Misses       1754     2417     +663

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcdan mcdan mcdan approved these changes
@tysonnorris tysonnorris Awaiting requested review from tysonnorris

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@selfxp @codecov-io @style95 @codecov-commenter @mcdan