Visitar URL original
[improve][client] Make table view support read the non-persistent topic by Demogorgon314 · Pull Request #18375 · apache/pulsar · GitHub
Skip to content

[improve][client] Make table view support read the non-persistent topic - #18375

Merged
Demogorgon314 merged 1 commit into
apache:masterfrom
Demogorgon314:Demogorgon314/make-table-view-support-non-persistent-topic
Nov 10, 2022
Merged

[improve][client] Make table view support read the non-persistent topic#18375
Demogorgon314 merged 1 commit into
apache:masterfrom
Demogorgon314:Demogorgon314/make-table-view-support-non-persistent-topic

Conversation

@Demogorgon314

@Demogorgon314 Demogorgon314 commented Nov 7, 2022 •
edited by momo-jun
Loading

Copy link
Copy Markdown
Member

Motivation

Currently, the table view only supports persistent topics with read compacted.

However, some data don't require persistent storage, like load data in PIP-192 #16691.

Modifications

Make table view support non-persistent topic

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: Demogorgon314#5

@Demogorgon314 Demogorgon314 self-assigned this Nov 7, 2022
@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Nov 7, 2022
@codecov-commenter

codecov-commenter commented Nov 8, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #18375 (7c82a17) into master (27186a1) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18375      +/-   ##
============================================
+ Coverage     46.99%   47.00%   +0.01%     
- Complexity    10348    10364      +16     
============================================
  Files           692      692              
  Lines         67764    67770       +6     
  Branches       7259     7260       +1     
============================================
+ Hits          31845    31857      +12     
- Misses        32328    32359      +31     
+ Partials       3591     3554      -37
Flag Coverage Δ
unittests 47.00% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...a/org/apache/pulsar/client/impl/TableViewImpl.java 0.00% <0.00%> (ø)
...lsar/broker/loadbalance/impl/ThresholdShedder.java 3.26% <0.00%> (-30.07%) ⬇️
.../apache/pulsar/broker/loadbalance/LoadManager.java 61.11% <0.00%> (-16.67%) ⬇️
...ce/schema/validator/StructSchemaDataValidator.java 52.38% <0.00%> (-9.53%) ⬇️
...org/apache/pulsar/broker/loadbalance/LoadData.java 58.33% <0.00%> (-8.34%) ⬇️
...pulsar/broker/service/PulsarCommandSenderImpl.java 73.29% <0.00%> (-4.72%) ⬇️
...roker/loadbalance/impl/ModularLoadManagerImpl.java 65.55% <0.00%> (-4.69%) ⬇️
...balance/impl/SimpleResourceAllocationPolicies.java 48.57% <0.00%> (-2.86%) ⬇️
...sar/broker/service/schema/SchemaRegistryStats.java 72.50% <0.00%> (-2.50%) ⬇️
...sar/broker/loadbalance/impl/LoadManagerShared.java 42.54% <0.00%> (-2.20%) ⬇️
... and 30 more

eolivelli
eolivelli approved these changes Nov 8, 2022
View reviewed changes

@eolivelli eolivelli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I believe that we can cherry-pick this to 2.11

@eolivelli eolivelli added this to the 2.12.0 milestone Nov 8, 2022
@Demogorgon314
Demogorgon314 merged commit 65baa6c into apache:master Nov 10, 2022
@heesung-sohn

heesung-sohn commented Nov 11, 2022

Copy link
Copy Markdown
Contributor

LGTM.

@mattisonchao

mattisonchao commented Nov 11, 2022

Copy link
Copy Markdown
Member

@Technoboy- I'm not sure if branch-2.11 has frozen the code. could you take a look at @eolivelli suggestions?

@Technoboy-

Technoboy- commented Nov 11, 2022

Copy link
Copy Markdown
Contributor

@Technoboy- I'm not sure if branch-2.11 has frozen the code. could you take a look at @eolivelli suggestions?

Sure, I will do this.

@Technoboy- Technoboy- modified the milestones: 2.12.0, 2.11.0 Nov 11, 2022
@heesung-sohn heesung-sohn mentioned this pull request Nov 17, 2022
Closed
@Demogorgon314 Demogorgon314 added doc-required Your PR changes impact docs and you will update later. and removed doc-not-needed Your PR changes do not impact docs labels Nov 22, 2022
@momo-jun

momo-jun commented Nov 29, 2022

Copy link
Copy Markdown
Contributor

Hi @Demogorgon314 Did you have any plans for the doc update?

@Demogorgon314

Demogorgon314 commented Nov 30, 2022

Copy link
Copy Markdown
Member Author

@momo-jun I'll add the doc later.

@Demogorgon314 Demogorgon314 mentioned this pull request Dec 13, 2022
Closed
1 of 4 tasks
@momo-jun momo-jun added doc-complete Your PR changes impact docs and the related docs have been already added. and removed doc-required Your PR changes impact docs and you will update later. labels Dec 13, 2022
@Demogorgon314 Demogorgon314 mentioned this pull request Jan 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merlimat merlimat merlimat approved these changes
@eolivelli eolivelli eolivelli approved these changes
@mattisonchao mattisonchao mattisonchao approved these changes
@nlu90 nlu90 Awaiting requested review from nlu90
@BewareMyPower BewareMyPower Awaiting requested review from BewareMyPower
@codelipenghui codelipenghui Awaiting requested review from codelipenghui

Assignees

@Demogorgon314 Demogorgon314

Labels

cherry-picked/branch-2.11 doc-complete Your PR changes impact docs and the related docs have been already added. ready-to-test

Projects

None yet

Milestone

2.11.0

Development

Successfully merging this pull request may close these issues.

8 participants

@Demogorgon314 @codecov-commenter @heesung-sohn @mattisonchao @Technoboy- @momo-jun @merlimat @eolivelli