Visitar URL original
[improve][broker] PIP-192 Implemented ExtensibleLoadManagerWrapper.getLoadBalancingMetrics() by heesung-sohn · Pull Request #19440 · apache/pulsar · GitHub
Skip to content

[improve][broker] PIP-192 Implemented ExtensibleLoadManagerWrapper.getLoadBalancingMetrics() - #19440

Merged
codelipenghui merged 3 commits into
apache:masterfrom
heesung-sohn:pip-192-metrics
Feb 11, 2023
Merged

[improve][broker] PIP-192 Implemented ExtensibleLoadManagerWrapper.getLoadBalancingMetrics()#19440
codelipenghui merged 3 commits into
apache:masterfrom
heesung-sohn:pip-192-metrics

Conversation

@heesung-sohn

@heesung-sohn heesung-sohn commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

Master Issue: #16691

Motivation

We will start raising PRs to implement PIP-192, #16691

Modifications

This PR implemented ExtensibleLoadManagerWrapper.getLoadBalancingMetrics()and its unit test.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • *Added unit tests.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

We will have separate PRs to update the Doc later.

Matching PR in forked repository

PR in forked repository: heesung-sohn#28

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Feb 7, 2023
gaoran10
gaoran10 reviewed Feb 7, 2023
View reviewed changes
Comment thread ...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java Resolved
Comment thread ...roker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/models/SplitCounter.java Resolved
Comment thread ...roker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/models/SplitCounter.java Resolved
Comment thread ...roker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/data/BrokerLoadData.java Resolved
@heesung-sohn heesung-sohn mentioned this pull request Feb 7, 2023
Closed
@Technoboy- Technoboy- added this to the 3.0.0 milestone Feb 8, 2023
@Technoboy- Technoboy- closed this Feb 9, 2023
@Technoboy- Technoboy- reopened this Feb 9, 2023
@codecov-commenter

codecov-commenter commented Feb 9, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 269 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.34%. Comparing base (aa7af10) to head (624ccd7).
⚠️ Report is 2859 commits behind head on master.

Files with missing lines Patch % Lines
...xtensions/channel/ServiceUnitStateChannelImpl.java 0.00% 74 Missing ⚠️
...r/loadbalance/extensions/models/UnloadCounter.java 0.00% 50 Missing ⚠️
...r/loadbalance/extensions/models/SplitDecision.java 0.00% 34 Missing ⚠️
...er/loadbalance/extensions/models/SplitCounter.java 0.00% 32 Missing ⚠️
...dbalance/extensions/ExtensibleLoadManagerImpl.java 0.00% 29 Missing ⚠️
...r/loadbalance/extensions/models/AssignCounter.java 0.00% 27 Missing ⚠️
...er/loadbalance/extensions/data/BrokerLoadData.java 0.00% 22 Missing ⚠️
...lance/extensions/ExtensibleLoadManagerWrapper.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #19440      +/-   ##
============================================
+ Coverage     64.20%   64.34%   +0.13%     
- Complexity    26265    26409     +144     
============================================
  Files          1832     1836       +4     
  Lines        134067   134570     +503     
  Branches      14753    14816      +63     
============================================
+ Hits          86077    86583     +506     
- Misses        40135    40156      +21     
+ Partials       7855     7831      -24
Flag Coverage Δ
inttests 24.85% <0.00%> (-0.07%) ⬇️
systests 25.48% <0.00%> (+<0.01%) ⬆️
unittests 61.62% <0.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../loadbalance/extensions/models/UnloadDecision.java 0.00% <ø> (ø)
...lance/extensions/ExtensibleLoadManagerWrapper.java 0.00% <0.00%> (ø)
...er/loadbalance/extensions/data/BrokerLoadData.java 0.00% <0.00%> (ø)
...r/loadbalance/extensions/models/AssignCounter.java 0.00% <0.00%> (ø)
...dbalance/extensions/ExtensibleLoadManagerImpl.java 5.88% <0.00%> (-1.60%) ⬇️
...er/loadbalance/extensions/models/SplitCounter.java 0.00% <0.00%> (ø)
...r/loadbalance/extensions/models/SplitDecision.java 0.00% <0.00%> (ø)
...r/loadbalance/extensions/models/UnloadCounter.java 0.00% <0.00%> (ø)
...xtensions/channel/ServiceUnitStateChannelImpl.java 0.73% <0.00%> (-0.24%) ⬇️

... and 129 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Technoboy-
Technoboy- approved these changes Feb 9, 2023
View reviewed changes

@Technoboy- Technoboy- left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codelipenghui codelipenghui reopened this Feb 11, 2023
@codelipenghui
codelipenghui merged commit 5c8f929 into apache:master Feb 11, 2023
@heesung-sohn heesung-sohn changed the title [improve][broker] Implemented ExtensibleLoadManagerWrapper.getLoadBalancingMetrics() [improve][broker] PIP-192 Implemented ExtensibleLoadManagerWrapper.getLoadBalancingMetrics() Feb 12, 2023
@heesung-sohn
heesung-sohn deleted the pip-192-metrics branch April 2, 2024 17:45
@merlimat merlimat mentioned this pull request Oct 24, 2026
Closed
1 of 2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes
@codelipenghui codelipenghui codelipenghui approved these changes
@gaoran10 gaoran10 gaoran10 approved these changes

Assignees

@heesung-sohn heesung-sohn

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@heesung-sohn @codecov-commenter @Technoboy- @codelipenghui @gaoran10