[type:refactor] externalize Huawei LTS logging to plugin-store - #7503

Review: externalize Huawei LTS logging to plugin-store

I reviewed this as a deletion/externalization PR (same family as #7499/#7500/#7501). The code removal is clean and the cross-dialect schema consistency — the exact spot where #7500 (casdoor) dropped orphan rows — is correct here.

What's done right

• Cross-dialect schema parity (verified). For plugin_id='43' the PR removes, across all six dialects (mysql, ob, og, oracle, pg, h2):
  • plugin row: 1 each
  • plugin_handle rows: 22 each (the 20 base fields + keyword/maskType/maskStatus + 2 sampleRate rows). The h2 file matches the 5 production dialects exactly — this is precisely where #7500 failed, and it is correct here.
  • namespace_plugin_rel row: 1 each
• Resource rows are per-dialect consistent with master, not a blind uniform count. mysql/ob delete 20 resource rows (both the block and pause menu trees); og/pg delete 10 (the block tree only). I confirmed against master that og/pg create-table.sql only ever contained the block tree (10 rows) and no pause tree, and that h2 schema.sql never carried these resource rows at all. So every dialect deletes exactly what its master contained — no orphan resource rows left behind.
• Compatibility contract retained. PluginEnum.LOGGING_HUAWEI_LTS(177, 0, "loggingHuaweiLts") is kept (only the javadoc wording changed to "compatibility enum"), and shenyu-common/.../PluginEnumTest.java (which references it) is untouched, so the kept test still compiles and passes.
• No dangling references. The e2e enum Plugin.LOGGINGHUAWEILTS is removed; gh search code shows no other (non-deleted) file references it. Remaining hits are either inside the deleted module tree, the intentionally-kept historical db/upgrade/*.sql archives, or the retained PluginEnum. shenyu-bootstrap/pom.xml's dependency is removed by the diff, and both aggregator poms (shenyu-plugin-logging/pom.xml, shenyu-spring-boot-starter-plugin/pom.xml) drop the module entries.
• Property / LICENSE scope safe. <huawei-log-sdk.version> and the two lts-sdk-* LICENSE entries are removed; the version property is referenced only by root pom.xml (definition) and the deleted module, so no kept pom resolves an undefined property.
• CI is fully green on every job (build, all shenyu-integrated-test-*, k8s-ingress, e2e, CodeQL, native-sql, build-docker-images).

Non-blocking suggestions

1. RELEASE-NOTES.md — please add an entry under Unreleased → Behavior Changes stating that the Huawei LTS logging implementation is no longer bundled in the core runtime and must be pulled from the plugin store. This is the only advance signal for downstream deployments that previously relied on the built-in starter.
2. docs/cloud-logging-pluginenum-compatibility.md is produced by renaming the module spring.factories (55% similarity). The content is correct, but since it is now a standalone doc, a short title/section header at the top would read better than the raw former license header block.
3. Cutover gate. The PR body still says "This PR remains draft" and references the receiving shenyu-plugin-store#13, yet the PR is open and CI is green. Merging should be coordinated with the store release as you've described; that is a release-process gate, not a code defect.
4. Named validation gap. The body notes Oracle/OpenGauss/OceanBase SQL execution is unverified. The row sets are byte-for-byte consistent with their respective master files (same IDs and counts), so risk is low, but it is worth a final manual confirm before the store cutover.

Conclusion

APPROVE. The externalization is complete and consistent; the only follow-ups are documentation/release-coordination items above. As with the other PRs in this series, please make sure the store-side delivery (shenyu-plugin-store#13) lands before merge.