Repository navigation
Conversation
arimu1
force-pushed
the
fix/1524-partial-update-script-fail
branch
2 times, most recently
from
September 12, 2026 23:17
22a519c to
af59912
Compare
Emit each contributed script in its own evaluate/priority-evaluate block so a runtime failure in one script does not prevent the client from running the rest.
arimu1
force-pushed
the
fix/1524-partial-update-script-fail
branch
from
September 12, 2026 23:17
af59912 to
dc5869f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When several scripts are contributed to an Ajax partial page update, Wicket previously combined them into a single
<evaluate>(or<priority-evaluate>) block. If one script throws at runtime, the browser stops executing the rest of that block, so later scripts and DOM updates never run.This change emits one evaluation block per contributed script, matching the client-side behavior in
wicket-ajax-jquery.jswhere each inline script is evaluated inside its own try/catch.Fixes #1524
Test plan
mvn -pl wicket-core-tests -am test -Dtest=XmlPartialPageUpdateTest -Dsurefire.failIfNoSpecifiedTests=falsefailingScriptDoesNotPreventSubsequentScriptsasserts two separate<evaluate>elements when two scripts are appended (repro from https://github.com/reiern70/ajaxevaluationfails)