Repository navigation
Conversation
Past MAX_EDIT_DISTANCE edits, report the region between the common prefix and suffix as a single ChangeDelta instead of allocating O(D^2) path nodes. Fixes assertj#2345
Member
|
Blocked by #2345 (comment). |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2345
Problem:
MyersDiffallocates O(D²) path nodes, sohasSameTextualContentAson large, very different files runs for minutes or hours.Fix: past
MAX_EDIT_DISTANCE(10,000) edits, report the region between the common prefix and suffix as a singleChangeDelta.Measurements (JDK 25, two runs each, allocation via
ThreadMXBean):Tests: new
MyersDiff_diff_Test(fails with the limit disabled: 2 deltas instead of 1); 89 diff/textual-content tests pass;./mvnw spotless:applyclean.Check List:
hasSameTextualContentAsis hanging with text file #2345🤖 Generated with Claude Code