Visitar URL original
[`pylint`] Ignore mutable type updates in `redefined-loop-name` (`PLW2901`) by KaufmanDmitriy · Pull Request #25733 · astral-sh/ruff · GitHub
Skip to content

[pylint] Ignore mutable type updates in redefined-loop-name (PLW2901) - #25733

Merged
ntBre merged 2 commits into
astral-sh:mainfrom
KaufmanDmitriy:PLW2901
Jul 9, 2026
Merged

[pylint] Ignore mutable type updates in redefined-loop-name (PLW2901)#25733
ntBre merged 2 commits into
astral-sh:mainfrom
KaufmanDmitriy:PLW2901

Conversation

@KaufmanDmitriy

@KaufmanDmitriy KaufmanDmitriy commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Addresses #24986

The rule has been updated to ignore cases where a mutable object is updated in-place. This makes the behavior consistent with how method‑based updates are already ignored.

Test Plan

Added new test cases

@astral-sh-bot
astral-sh-bot Bot requested a review from ntBre June 7, 2026 18:17
@astral-sh-bot

astral-sh-bot Bot commented Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

ntBre
ntBre reviewed Jun 8, 2026
View reviewed changes

@ntBre ntBre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I had a couple of suggestions for simplification and a request for the tests.

Comment thread crates/ruff_linter/src/rules/pylint/rules/redefined_loop_name.rs Resolved
Comment thread crates/ruff_linter/src/rules/pylint/rules/redefined_loop_name.rs Resolved
Comment thread crates/ruff_linter/resources/test/fixtures/pylint/redefined_loop_name.py Resolved
Comment thread crates/ruff_linter/src/rules/pylint/rules/redefined_loop_name.rs Resolved
@ntBre ntBre changed the title [pylint] Ignore mutable type updates in redefined-loop-name (PLW2901) [pylint] Ignore mutable type updates in redefined-loop-name (PLW2901) Jun 8, 2026
@ntBre ntBre linked an issue Jun 8, 2026 that may be closed by this pull request
PLW2901 inconsistent with ior/iadd operations vx their method counterparts when in-place modiying #24986
Closed
@ntBre ntBre added the rule Implementing or modifying a lint rule label Jun 8, 2026
@KaufmanDmitriy

KaufmanDmitriy commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

@ntBre Hi, I made changes based on your suggestions, please review.

@KaufmanDmitriy
KaufmanDmitriy requested a review from ntBre June 11, 2026 15:18
ntBre
ntBre approved these changes Jul 9, 2026
View reviewed changes

@ntBre ntBre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Sorry for the delay here, this looks great.

@ntBre
ntBre merged commit fb15b89 into astral-sh:main Jul 9, 2026
45 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jul 16, 2026
Merged
@scottames-github-bot scottames-github-bot Bot mentioned this pull request Jul 21, 2026
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntBre ntBre ntBre approved these changes

Assignees

No one assigned

Labels

rule Implementing or modifying a lint rule

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PLW2901 inconsistent with ior/iadd operations vx their method counterparts when in-place modiying

2 participants

@KaufmanDmitriy @ntBre