Visitar URL original
Correct HTTP cache request directives by zaniebot · Pull Request #200 · astral-sh/uv-dev · GitHub
Skip to content

Correct HTTP cache request directives - #200

Draft
zaniebot wants to merge 1 commit into
mainfrom
zb/bughunt200/163-fix-http-cache-request-directives
Draft

zaniebot wants to merge 1 commit into
mainfrom
zb/bughunt200/163-fix-http-cache-request-directives

Conversation

@zaniebot

@zaniebot zaniebot commented Jul 16, 2026 •

Copy link
Copy Markdown
Collaborator

Cached responses incorrectly become stale under min-fresh because the calculation uses epoch time; max-stale is read from the original request instead of the current one. Apply both directives to the cached response's age, as required by RFC 9111. This builds on the cache-age and exact-expiration fixes in uv#20178 and uv#20183.

@zaniebot
zaniebot force-pushed the zb/bughunt200/163-fix-http-cache-request-directives branch from 56ea6c0 to 877d64b Compare July 16, 2026 02:34
@astral-automations-bot
astral-automations-bot Bot force-pushed the zb/bughunt200/163-fix-http-cache-request-directives branch from 877d64b to 70f610a Compare July 17, 2026 21:43
@zaniebot zaniebot added priority:2 Important: bounded correctness, release reliability, committed work, or proven performance gains. size:2 Moderate: one subsystem with meaningful invariants, edge cases, or operational evidence to inspect. bug Something isn't working compatibility Compatibility with a specification or another tool risk:1 Negligible risk of localized mistakes that are obvious and easy to correct. labels Sep 9, 2026
@astral-automations-bot
astral-automations-bot Bot force-pushed the zb/bughunt200/163-fix-http-cache-request-directives branch from 70f610a to 7e47410 Compare September 30, 2026 14:45
@codspeed

codspeed Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ 8 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

✅ 54 untouched benchmarks
⏩ 35 skipped benchmarks1


Comparing zb/bughunt200/163-fix-http-cache-request-directives (9de96dc) with main (1a2544a)2

Open in CodSpeed

Footnotes

  1. 35 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (8dcc24e) during the generation of this report, so 1a2544a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@astral-automations-bot
astral-automations-bot Bot force-pushed the zb/bughunt200/163-fix-http-cache-request-directives branch from 7e47410 to b44714e Compare October 1, 2026 16:49
@astral-automations-bot
astral-automations-bot Bot force-pushed the zb/bughunt200/163-fix-http-cache-request-directives branch from b44714e to 9de96dc Compare October 9, 2026 18:55

This branch was successfully deployed

1 active deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working compatibility Compatibility with a specification or another tool priority:2 Important: bounded correctness, release reliability, committed work, or proven performance gains. risk:1 Negligible risk of localized mistakes that are obvious and easy to correct. size:2 Moderate: one subsystem with meaningful invariants, edge cases, or operational evidence to inspect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants