Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundled
PrimitiveValuetype excludesundefined, so strict TypeScript rejects optional fields and explicit undefined values thatexpand()already accepts. Includeundefinedin the alias to match the existing scalar, list and record handling.The consumer fixture covers these inputs and keeps functions, symbols and deeper objects outside the accepted types. It produces six TS2322 errors with the original declaration and none with this change.
Fixes #79.
Checks:
tsc --strict --module NodeNext --target ES2022 --noEmit type-tests/expand.tsnpm teston Node 18.20.8: 159 tests pass, with no failures or skips, using the pinned URI-template test corpus.The compiler fixture is checked separately from
npm test; no compiler dependency or package script is added.