Visitar URL original
Use new HTTP and Socket API and improve documentation and examples by SimonFrings · Pull Request #72 · clue/reactphp-docker · GitHub
Skip to content

Use new HTTP and Socket API and improve documentation and examples - #72

Merged
clue merged 3 commits into
clue:masterfrom
SimonFrings:docs
Sep 30, 2021
Merged

Use new HTTP and Socket API and improve documentation and examples#72
clue merged 3 commits into
clue:masterfrom
SimonFrings:docs

Conversation

@SimonFrings

@SimonFrings SimonFrings commented Sep 30, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Builds on top of #71, reactphp/socket#263 and reactphp/http#417.

@clue clue added this to the v1.4.0 milestone Sep 30, 2021
clue
clue requested changes Sep 30, 2021
View reviewed changes

@clue clue left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for looking into this, added some minor remarks below 👍

Comment thread src/Client.php Resolved
Comment thread src/Client.php Resolved
Comment thread tests/FunctionalClientTest.php Resolved
Comment thread tests/IntegrationTest.php Resolved
Comment thread tests/IntegrationTest.php Resolved
@SimonFrings
SimonFrings force-pushed the docs branch 3 times, most recently from 2d1ce0d to bd897fd Compare September 30, 2021 11:16
clue
clue approved these changes Sep 30, 2021
View reviewed changes

@clue clue left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

@clue
clue merged commit 1813c68 into clue:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clue clue clue approved these changes

Assignees

No one assigned

Labels

maintenance

Projects

None yet

Milestone

v1.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@SimonFrings @clue