Visitar URL original
Use reactphp/async instead of clue/reactphp-block by dinooo13 · Pull Request #50 · clue/reactphp-http-proxy · GitHub
Skip to content

Use reactphp/async instead of clue/reactphp-block - #50

Closed
dinooo13 wants to merge 1 commit into
clue:1.xfrom
dinooo13:async
Closed

Use reactphp/async instead of clue/reactphp-block#50
dinooo13 wants to merge 1 commit into
clue:1.xfrom
dinooo13:async

Conversation

@dinooo13

@dinooo13 dinooo13 commented Oct 4, 2022

Copy link
Copy Markdown
Contributor

SimonFrings
SimonFrings reviewed Oct 5, 2022
View reviewed changes

@SimonFrings SimonFrings left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing I noticed

Comment thread tests/FunctionalTest.php Resolved
@dinooo13
dinooo13 requested a review from SimonFrings November 19, 2022 20:29
@SimonFrings SimonFrings added this to the v1.9.0 milestone Nov 14, 2023
SimonFrings
SimonFrings approved these changes Nov 14, 2023
View reviewed changes

@SimonFrings SimonFrings left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request here looks good, let's get this in 👍

@SimonFrings
SimonFrings requested a review from clue November 14, 2023 16:08
@SimonFrings

SimonFrings commented Nov 15, 2023

Copy link
Copy Markdown
Contributor

@dinooo13 Just noticed, the test suite is currently not running through as it can be seen in #53 and we need to update our test suite. @yadaiio created a pull request for this in #54. Once this is merged we have to come back to this one here and rebase once. Additionally, we'll probably encounter a conflict in the composer.json file when rebasing, as #54 updates the PHPUnit versions which are right below you changes.

I will give an update in here once #54 is merged so we can move on and get this pull request in 👍

@SimonFrings

SimonFrings commented Feb 26, 2024

Copy link
Copy Markdown
Contributor

@dinooo13 With #54 merged I think we can rebase in here and then get this in 👍

@SimonFrings SimonFrings mentioned this pull request Apr 10, 2024
Merged
@clue clue closed this in #57 Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clue clue Awaiting requested review from clue
1 more reviewer
@SimonFrings SimonFrings SimonFrings approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

maintenance

Projects

None yet

Milestone

v1.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dinooo13 @SimonFrings