Visitar URL original
Add missing $ to the magic property names in phpdoc. by tristanlins · Pull Request #2 · contao/core-bundle · GitHub
Skip to content

Add missing $ to the magic property names in phpdoc. - #2

Merged
leofeyer merged 1 commit into
contao:feature/ide-compatfrom
tristanlins:feature/ide-compat
Aug 13, 2014
Merged

leofeyer merged 1 commit into
contao:feature/ide-compatfrom
tristanlins:feature/ide-compat

Conversation

@tristanlins

Copy link
Copy Markdown
Contributor

@leofeyer
leofeyer merged commit 86cf27b into contao:feature/ide-compat Aug 13, 2014
@tristanlins
tristanlins deleted the feature/ide-compat branch October 27, 2014 09:36
leofeyer pushed a commit that referenced this pull request Nov 7, 2014
Made Image class way more modular and object oriented
discordier pushed a commit to discordier/core-bundle that referenced this pull request Apr 10, 2015
Made Image class way more modular and object oriented
leofeyer pushed a commit that referenced this pull request Jul 24, 2015
Made Image class way more modular and object oriented
leofeyer pushed a commit that referenced this pull request Oct 22, 2015
Test AdapterFactory methods and fix createInstance()
leofeyer pushed a commit that referenced this pull request Nov 9, 2015
@goransi goransi mentioned this pull request Feb 1, 2018
leofeyer pushed a commit that referenced this pull request Feb 21, 2019
Description
-----------

Here's an early draft of @terminal42's approach to new entry points.

- [x] ~~instead of having multiple entry points (`app.php`, `app_dev.php`), we want to have only one entry point (`index.php` as in Symfony 4).~~ Not possible, we still need a separate entry point to have a different URL to bypass the cache.
- [x] to know the user without needing to boot the kernel, a JWT cookie can be used

the JWT can tell
 - [x] ~whether to bypass the cache (if JWT token says the user is logged into the backend)~ If the user is allowed to use the front controller that bypasses the cache
 - [x] to enable or disable debug mode from the backend
 - [x] ~to enable or disable preview mode (without the iframe)~ Preview is determined by the user token, and we shouldn't change that for BC

this allows us to
 - [ ] remove dependency on `terminal42/header-replay-bundle` to bypass cache if a user is logged in
 - [ ] remove dependency on session/user/ip etc. to bypass (lexik) maintenance mode
 - [x] allow to use the debug mode without needing to activate it in the Contao Manager
 - probably a lot more 🎉 

regarding the JWT
 - [x] because we cannot use the kernel secret (the kernel/container is not bootet yet), the secret must be automatically generated and stored in a temporary file (e.g. `/var/cache/jwt-secret`)
 - [x] the JWT can only be signed using this secret, we can't encrypt it because we cannot rely on OpenSSL to generate a valid certificate on-the-fly

Commits
-------

a206ca81 Initial draft of new entry points
479ae5c9 Require firebase/php-jwt (same lib the Contao Manager uses)
b7b6dee7 Draft of JWT as kernel config
26546f3e Use separate entry points to bypass the cache
0a339d17 Introducing JwtManager
d4729e6a Renamed preview.php to admin.php
8913fa27 Set and delete cookie on login/logout
5ea414f2 Do not redirect on the login page
afa16616 Fixed bugs in JWT manager
bed865ab Re-add changes that were lost during rebase
73afe2c9 Renamed the entry point
5453876f Add the entry point to the preview link in the backend
d16ca38e Add debug mode switch to preview bar
2c2cab7c Fix JWT handling in preview entry point
af494290 Do not enable debug mode when logging in as admin
94d39606 Add debug toggle menu for backend admins
04f2f068 Correctly redirect back after backend login
ac82f6f1 Strip the tags header from preview responses
276592c7 Redirect to backend login after backend logout
ab5974e5 Fixed unit tests for login and logout handlers
cf5dd1d7 Added unit tests (#2)
e4260f5f Fix the coding style
95a116f3 Merge branch 'master' into feature/entry-point
f5bd0b08 Fix a potential null pointer exception
leofeyer pushed a commit that referenced this pull request Nov 1, 2019
…es command (see #866)

Description
-----------

Together with @Toflar we had a hard time debugging why the `contao:resize-images` command stopped at some point and did not want to continue. The error message was quite unclear especially that the requested file existed:

```
6/77b26349-9084f1ba.jpg......... failed
Unable to open image /var/www/vhosts/domain.tld/httpdocs/releases/233/assets/images/../../var/pim-images/77b26349.jpg
```

So we decided to introduce an option that allows to output more verbose error message simply by executing command in verbose mode `contao:resize-images -v`:

```
f/8ac5c4ec-213df40b.jpg.............. failed

 [ERROR] ImagickException: cache resources exhausted
         `/var/www/vhosts/domain.tld/httpdocs/releases/233/assets/images/../../var/pim-images/8ac5c4ec.jpg' @
         error/cache.c/OpenPixelCache/3864 in
         /var/www/vhosts/domain.tld/httpdocs/releases/233/vendor/imagine/imagine/src/Imagick/Imagine.php:69
         Stack trace:
         #0 /var/www/vhosts/domain.tld/httpdocs/releases/233/vendor/imagine/imagine/src/Imagick/Imagine.php(69):
         Imagick->__construct('/var/www/vhosts...')
         #1 /var/www/vhosts/domain.tld/httpdocs/releases/233/vendor/contao/image/src/Resizer.php(93):
         Imagine\Imagick\Imagine->open('/var/www/vhosts...')
         #2 /var/www/vhosts/domain.tld/httpdocs/releases/233/vendor/contao/image/src/DeferredResizer.php(185):
         Contao\Image\Resizer->executeResize(Object(Contao\Image\Image), Object(Contao\Image\ResizeCoordinates),
         '/var/www/vhosts...', Object(Contao\Image\ResizeOptions))
         #3 /var/www/vhosts/domain.tld/httpdocs/releases/233/vendor/contao/image/src/DeferredResizer.php(108):
         Contao\Image\DeferredResizer->executeDeferredResize('f/8ac5c4ec-213d...', Array,
         Object(Imagine\Imagick\Imagine))
         #4
         /var/www/vhosts/domain.tld/httpdocs/releases/233/vendor/contao/core-bundle/src/Command/ResizeImagesComma
         nd.php(189): Contao\Image\DeferredResizer->resizeDeferredImage(Object(Contao\Image\DeferredImage), false)
         #5
         /var/www/vhosts/domain.tld/httpdocs/releases/233/vendor/contao/core-bundle/src/Command/ResizeImagesComma
         nd.php(166): Contao\CoreBundle\Command\ResizeImagesCommand->resizeImage('f/8ac5c4ec-213d...',
         Object(Symfony\Component\Console\Style\SymfonyStyle))
         #6 /var/www/vhosts/domain.tld/httpdocs/releases/233/vendor/symfony/console/Command/Command.php(255):
```

Commits
-------

e9c6de99 Allow to output more verbose error messages in contao:resize-images command
leofeyer pushed a commit that referenced this pull request Aug 4, 2020
Description
-----------

With @Toflar we have discovered by accident that if a URL is double-encoded (for some reason, doesn't matter) the Contao's `RouteProvider` will eventually throw an error trying to query a database.

```
URL original: drachenlochmuseum-v%25c3%25a4ttis.html
URL decoded: drachenlochmuseum-v%c3%a4ttis.html
URL decoded 2nd time: drachenlochmuseum-vättis.html
```

The decoded URL is used in the database query and that fails because the database driver would like to replace wildcards `%c` with parameters that were not provided.

Stack trace:

```
Exception: Too few arguments to build the query string
#27 vendor/contao/core-bundle/src/Resources/contao/library/Contao/Database/Statement.php(304): replaceWildcards
#26 vendor/contao/core-bundle/src/Resources/contao/library/Contao/Database/Statement.php(249): execute
#25 vendor/contao/core-bundle/src/Resources/contao/library/Contao/Model.php(1102): find
#24 vendor/contao/core-bundle/src/Resources/contao/library/Contao/Model.php(973): findBy
#23 vendor/contao/core-bundle/src/Framework/Adapter.php(38): __call
#22 vendor/contao/core-bundle/src/Routing/RouteProvider.php(493): findPages
#21 vendor/contao/core-bundle/src/Routing/RouteProvider.php(88): getRouteCollectionForRequest
#20 vendor/contao/core-bundle/src/Routing/LegacyRouteProvider.php(43): getRouteCollectionForRequest
#19 vendor/symfony-cmf/routing/src/NestedMatcher/NestedMatcher.php(141): matchRequest
#18 vendor/contao/core-bundle/src/Routing/Matcher/LegacyMatcher.php(69): matchRequest
#17 vendor/symfony-cmf/routing/src/DynamicRouter.php(271): matchRequest
#16 vendor/symfony-cmf/routing/src/ChainRouter.php(188): doMatch
#15 vendor/symfony-cmf/routing/src/ChainRouter.php(158): matchRequest
#14 vendor/symfony/http-kernel/EventListener/RouterListener.php(115): onKernelRequest
#13 vendor/symfony/event-dispatcher/EventDispatcher.php(212): doDispatch
#12 vendor/symfony/event-dispatcher/EventDispatcher.php(44): dispatch
#11 vendor/symfony/http-kernel/HttpKernel.php(126): handleRaw
#10 vendor/symfony/http-kernel/HttpKernel.php(67): handle
#9 vendor/symfony/http-kernel/Kernel.php(198): handle
#8 vendor/symfony/http-kernel/HttpCache/SubRequestHandler.php(85): handle
#7 vendor/symfony/http-kernel/HttpCache/HttpCache.php(448): forward
#6 vendor/symfony/framework-bundle/HttpCache/HttpCache.php(57): forward
#5 vendor/symfony/http-kernel/HttpCache/HttpCache.php(420): fetch
#4 vendor/contao/manager-bundle/src/HttpKernel/ContaoCache.php(46): fetch
#3 vendor/symfony/http-kernel/HttpCache/HttpCache.php(317): lookup
#2 vendor/symfony/http-kernel/HttpCache/HttpCache.php(192): handle
#1 vendor/friendsofsymfony/http-cache/src/SymfonyCache/EventDispatchingHttpCache.php(98): handle
#0 web/app.php(58): null
```

Commits
-------

8ae25820 Fix a potential error if the URL has percentage in it
8caaf252 Fix unit tests
509f7624 Correctly encode the page aliases
leofeyer pushed a commit that referenced this pull request Mar 15, 2021
Description
-----------

| Q                | A
| -----------------| ---
| Fixed issues     | partly solves #2316 
| Docs PR or issue | -

I'm working on test isolation. This part makes sure tests aren't reading temporary data from each other. This effectively means that a test should never write into the `Fixtures` dir (or anywhere else inside the source directories). If temporary files need to be created this now will happen inside the test's own `tmp` dir.

While working on these files, I'm also adjusting the following for consistency:

1) Refactoring path operations to use `Path`
1) Removing private property `$filesystem`  (if we want to share the `Filesystem` instance across tests, we should imo add it to `ContaoTestCase` as a static property)
1) Use `$filesystem` instead of `$fs` everywhere

Following changes needed for #2316 (but unrelated to writing files) are also part of this PR:

1) Reset template loader every time (was missing once, now in `tearDown`).
1) Do not share `ContaoCacheWarmer` instance.

Commits
-------

4e5fa522 never write into tests/Fixture dir
baf27c49 always reset TemplateLoader
827d5f27 add missing file
c3c0e628 backport changes from #1918
2aeb2eeb CS
79272861 Merge branch '4.9' into bugfix/test-order/do-not-write-in-fixture-dir
a50db5c1 Fix the prefer-lowest tests
71e7cfa7 clear var directory after running functional tests
c466d7e5 bugfix for bugfix/test-order/do-not-write-in-fixture-dir
3b4fdb40 Merge pull request #2 from fritzmg/fix-bugfix/test-order/do-not-write-in-fixture-dir

bugfix for bugfix/test-order/do-not-write-in-fixture-dir
9891c55f fix filepath comparisons
a25d552e Merge pull request #3 from fritzmg/fix-imagefactorytest-filepath-comparisons

Fix filepath comparisons
leofeyer pushed a commit that referenced this pull request Jun 7, 2021
Description
-----------

This PR

* ensures the new `ResponseContext` does contain clean and unencoded values in preparation for the future (one thing less to migrate)
* unifies the handling of insert tags for meta description. Sometimes it was stripped, sometimes replaced

Commits
-------

3b9922c8 Ensure clean response context and unify meta handling
6b286598 Move description shortening to template
ee9eedff Add StringUtil::getRawDecodedValue()
f7969ba1 Add StringUtil::getRawDecodedValueFromHtml()
5821b918 Test and fix getRawDecodedValueFromHtml method
84a80bdd Fix tests
7980cdaa Improve insert tag braces encoding
bd105385 Merge pull request #2 from ausi/fix/response-context-encoding
1054d98f Use our own string util to shorten the description
a5586c0e CS
3bd69849 Improve string util test
cbd11c42 Merge pull request #3 from ausi/fix/improve-string-util-test
4dc2d384 CS
5a5578f8 Rename to StringUtil methods
207df742 CS
leofeyer pushed a commit that referenced this pull request Nov 15, 2021
Description
-----------

See contao/contao#3215 (comment)

Commits
-------

d79da637 Replace deprecated security.encoder_factory with security.password_hasher_factory
9fe6a645 Fix UserPasswordCommand
e0d6d9ac Fix AuthenticationProvider
06f97784 Fix UserPasswordCommand?
c6ca3d55 CS
0e200d00 Remove leftovers
c792349b Mock SwitchUserToken properly
0ce699e0 Remove deprecation of InputBag::get()
509800c9 Implement new Symfony 5.3 Security interfaces
b579d286 CS
2b2297fc CS
e28b713d Add deprecation
06fb8a11 Remove test
365aa322 CS
c6a4781d Adjust the phpDoc deprecations
b022da0b Use password_hashers instead of encoders in security configuration
1754635e Add a LogoutSuccessListener and deprecate the LogoutSuccessHandler
42547d6e CS
9d5fcdfa Update readme
73a85d10 Use FQCNs for the new listeners (#2)
c7152618 Fix more deprecations
e14a8873 Deprecate ContaoLoginAuthenticationListener and AuthenticationProvider
7e56daf3 Fix CS
e58cc495 Fix deprecations
b0c7ec78 Revert "Use FQCNs for the new listeners (#2)"

This reverts commit 73a85d1026b5a423ec7bb4e1e3b323c972baf9e9.
7ba98830 CS
f1e0d239 Fix two deprecation messages
leofeyer pushed a commit that referenced this pull request May 23, 2024
…licating a page (see #7102)

Description
-----------

If a user who is not an admin copies a page, the articles (and thus all content) are no longer copied, as it was the case in Contao 4. Instead a new empty article is created.
This is because the check whether the user is allowed to create the articles depends on the pagemountCache in the BackendAccessVoter, which is only set once per request and user. 
As the page does not yet exist when the cache is first set and has not been reset after the page has been created, the check as to whether the user is allowed to access the newly created page fails.

This PR adds a check if a new page has been created before accessing the pagemountCache in the BackendAccessVoter and clears the cache if this is the case.


Steps to reproduce:

1. Login as a user without admin privileges
2. Copy and paste a page that has content elements in its article
3. The original article(s) will not be copied but a new one will be created

Commits
-------

45f2cbb5 Change pagemountCache structure in BackendAccessVoter
5257361d Store true/false in the pagemountsCache
c53c4e10 Merge pull request #1 from aschempp/fix/page-access
f30b8f05 Merge pull request #2 from lukasbableck/5.3
ed3f337c run rector
479dad1c run ecs fix
0c3bba24 Revert "Change pagemountCache structure in BackendAccessVoter"
d031b280 check if page is in pagemountsCache and rebuild cache if not before r…

Co-authored-by: aschempp <andreas.schempp@terminal42.ch>
leofeyer pushed a commit that referenced this pull request May 29, 2024
… #7248)

Description
-----------

If a `tl_article` record still contains `keywords` from previous Contao versions and you reference this article in an `article` content element, the following warning will appear in the back end:

```
ErrorException: Warning: Undefined global variable $TL_KEYWORDS
#24 /vendor/contao/core-bundle/src/Resources/contao/modules/ModuleArticle.php(207): Contao\ModuleArticle::compile
#23 /vendor/contao/core-bundle/src/Resources/contao/modules/Module.php(214): Contao\Module::generate
#22 /vendor/contao/core-bundle/src/Resources/contao/modules/ModuleArticle.php(70): Contao\ModuleArticle::generate
#21 /vendor/contao/core-bundle/src/Resources/contao/library/Contao/Controller.php(550): Contao\Controller::getArticle
#20 /vendor/contao/core-bundle/src/Resources/contao/elements/ContentArticle.php(30): Contao\ContentArticle::generate
#19 /vendor/contao/core-bundle/src/Resources/contao/library/Contao/Controller.php(622): Contao\Controller::getContentElement
#18 /var/cache/prod/contao/dca/tl_content.php(318): tl_content::addCteType
#17 /vendor/contao/core-bundle/src/Resources/contao/drivers/DC_Table.php(4717): Contao\DC_Table::parentView
#16 /vendor/contao/core-bundle/src/Resources/contao/drivers/DC_Table.php(313): Contao\DC_Table::showAll
#15 /vendor/contao/core-bundle/src/Resources/contao/classes/Backend.php(667): Contao\Backend::getBackendModule
#14 /vendor/contao/core-bundle/src/Resources/contao/controllers/BackendMain.php(168): Contao\BackendMain::run
#13 /vendor/contao/core-bundle/src/Controller/BackendController.php(49): Contao\CoreBundle\Controller\BackendController::mainAction
#12 /vendor/symfony/http-kernel/HttpKernel.php(163): Symfony\Component\HttpKernel\HttpKernel::handleRaw
#11 /vendor/symfony/http-kernel/HttpKernel.php(75): Symfony\Component\HttpKernel\HttpKernel::handle
#10 /vendor/symfony/http-kernel/Kernel.php(202): Symfony\Component\HttpKernel\Kernel::handle
#9 /vendor/symfony/http-kernel/HttpCache/SubRequestHandler.php(86): Symfony\Component\HttpKernel\HttpCache\SubRequestHandler::handle
#8 /vendor/symfony/http-kernel/HttpCache/HttpCache.php(481): Symfony\Component\HttpKernel\HttpCache\HttpCache::forward
#7 /vendor/symfony/framework-bundle/HttpCache/HttpCache.php(73): Symfony\Bundle\FrameworkBundle\HttpCache\HttpCache::forward
#6 /vendor/symfony/http-kernel/HttpCache/HttpCache.php(454): Symfony\Component\HttpKernel\HttpCache\HttpCache::fetch
#5 /vendor/contao/manager-bundle/src/HttpKernel/ContaoCache.php(66): Contao\ManagerBundle\HttpKernel\ContaoCache::fetch
#4 /vendor/symfony/http-kernel/HttpCache/HttpCache.php(348): Symfony\Component\HttpKernel\HttpCache\HttpCache::lookup
#3 /vendor/symfony/http-kernel/HttpCache/HttpCache.php(226): Symfony\Component\HttpKernel\HttpCache\HttpCache::handle
#2 /vendor/friendsofsymfony/http-cache/src/SymfonyCache/EventDispatchingHttpCache.php(96): Contao\ManagerBundle\HttpKernel\ContaoCache::handle
#1 /web/index.php(44): require
#0 /web/app.php(13): null
```

This is because `$GLOBALS['TL_KEYWORDS']` is only initialised in the front end within `PageRegular::prepare()`. This PR simply ignores it if not set.

Commits
-------

e54dc2b8 fix warning when legacy keywords are present
leofeyer pushed a commit that referenced this pull request Jun 7, 2024
…#7268)

Description
-----------

Got this erro in my logs:

```
RuntimeException: The Symfony container is not available, did you initialize the Contao framework? in vendor/contao/core-bundle/contao/library/Contao/System.php:143 Stack trace:
#0 vendor/contao/core-bundle/contao/library/Contao/System.php(97): Contao\System->import('Contao\\Config', 'Config')
#1 vendor/contao/core-bundle/contao/library/Contao/DcaExtractor.php(105): Contao\System->__construct()
#2 vendor/contao/core-bundle/contao/library/Contao/DcaExtractor.php(140): Contao\DcaExtractor->__construct('tl_opt_in')
#3 vendor/contao/core-bundle/contao/library/Contao/Model.php(291): Contao\DcaExtractor::getInstance('tl_opt_in')
#4 vendor/contao/core-bundle/contao/library/Contao/Model.php(1084): Contao\Model::getUniqueFields()
#5 vendor/contao/core-bundle/contao/models/OptInModel.php(87): Contao\Model::findBy(Array, 1716888783, Array)
#6 vendor/contao/core-bundle/src/Framework/Adapter.php(38): Contao\OptInModel::findExpiredTokens()
#7 vendor/contao/core-bundle/src/OptIn/OptIn.php(76): Contao\CoreBundle\Framework\Adapter->__call('findExpiredToke...', Array)
#8 vendor/contao/core-bundle/src/Cron/PurgeOptInTokensCron.php(30): Contao\CoreBundle\OptIn\OptIn->purgeTokens()
#9 vendor/contao/core-bundle/src/Cron/CronJob.php(44): Contao\CoreBundle\Cron\PurgeOptInTokensCron->__invoke('cli')
#10 vendor/contao/core-bundle/src/Cron/Cron.php(197): Contao\CoreBundle\Cron\CronJob->__invoke('cli')
#11 vendor/contao/core-bundle/src/Cron/Cron.php(182): Contao\CoreBundle\Cron\Cron->executeCrons(Array, 'cli', Object(Closure))
#12 vendor/contao/core-bundle/src/Cron/Cron.php(97): Contao\CoreBundle\Cron\Cron->doRun(Array, 'cli', false)
#13 vendor/contao/core-bundle/src/Command/CronCommand.php(53): Contao\CoreBundle\Cron\Cron->run('cli', false)
#14 vendor/symfony/console/Command/Command.php(326): Contao\CoreBundle\Command\CronCommand->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#15 vendor/symfony/console/Application.php(1096): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#16 vendor/symfony/framework-bundle/Console/Application.php(126): Symfony\Component\Console\Application->doRunCommand(Object(Contao\CoreBundle\Command\CronCommand), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#17 vendor/symfony/console/Application.php(324): Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand(Object(Contao\CoreBundle\Command\CronCommand), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#18 vendor/symfony/framework-bundle/Console/Application.php(80): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#19 vendor/symfony/console/Application.php(175): Symfony\Bundle\FrameworkBundle\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#20 vendor/contao/manager-bundle/bin/contao-console(40): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput))
#21 vendor/bin/contao-console(119):  #22
```

Commits
-------

9ee76a07 Initialize the Contao framework when working with opt-in tokens
leofeyer pushed a commit that referenced this pull request Aug 27, 2024
Description
-----------

If you create a `downloads` content element, but then immediately click "Back", the following error will occur:

```
TypeError:
Contao\CoreBundle\Filesystem\FilesystemUtil::listContentsFromSerialized(): Argument #2 ($sources) must be of type array|string, null given, called in vendor\contao\contao\core-bundle\src\Controller\ContentElement\DownloadsController.php on line 86

  at vendor\contao\contao\core-bundle\src\Filesystem\FilesystemUtil.php:37
  at Contao\CoreBundle\Filesystem\FilesystemUtil::listContentsFromSerialized()
     (vendor\contao\contao\core-bundle\src\Controller\ContentElement\DownloadsController.php:86)
  at Contao\CoreBundle\Controller\ContentElement\DownloadsController->getFilesystemItems()
     (vendor\contao\contao\core-bundle\src\Controller\ContentElement\DownloadsController.php:41)
  at Contao\CoreBundle\Controller\ContentElement\DownloadsController->getResponse()
     (vendor\contao\contao\core-bundle\src\Controller\ContentElement\AbstractContentElementController.php:40)
  at Contao\CoreBundle\Controller\ContentElement\AbstractContentElementController->__invoke()
     (vendor\contao\contao\core-bundle\src\Controller\ContentElement\AbstractDownloadContentElementController.php:40)
  at Contao\CoreBundle\Controller\ContentElement\AbstractDownloadContentElementController->__invoke()
     (vendor\symfony\http-kernel\HttpKernel.php:181)
  at Symfony\Component\HttpKernel\HttpKernel->handleRaw()
     (vendor\symfony\http-kernel\HttpKernel.php:76)
  at Symfony\Component\HttpKernel\HttpKernel->handle()
     (vendor\symfony\http-kernel\HttpCache\SubRequestHandler.php:86)
  at Symfony\Component\HttpKernel\HttpCache\SubRequestHandler::handle()
     (vendor\symfony\http-kernel\Fragment\InlineFragmentRenderer.php:78)
  at Symfony\Component\HttpKernel\Fragment\InlineFragmentRenderer->render()
     (vendor\symfony\http-kernel\Fragment\FragmentHandler.php:83)
  at Symfony\Component\HttpKernel\Fragment\FragmentHandler->render()
     (vendor\contao\contao\core-bundle\src\Fragment\FragmentHandler.php:66)
  at Contao\CoreBundle\Fragment\FragmentHandler->render()
     (vendor\contao\contao\core-bundle\contao\elements\ContentProxy.php:74)
  at Contao\ContentProxy->generate()
     (vendor\contao\contao\core-bundle\contao\library\Contao\Controller.php:601)
  at Contao\Controller::getContentElement()
     (vendor\contao\contao\core-bundle\contao\dca\tl_content.php:1007)
  at tl_content->addCteType()
     (vendor\contao\contao\core-bundle\contao\drivers\DC_Table.php:5014)
  at Contao\DC_Table->parentView()
     (vendor\contao\contao\core-bundle\contao\drivers\DC_Table.php:468)
  at Contao\DC_Table->showAll()
     (vendor\contao\contao\core-bundle\contao\classes\Backend.php:546)
  at Contao\Backend->getBackendModule()
     (vendor\contao\contao\core-bundle\contao\controllers\BackendMain.php:144)
  at Contao\BackendMain->run()
     (vendor\contao\contao\core-bundle\src\Controller\BackendController.php:44)
  at Contao\CoreBundle\Controller\BackendController->mainAction()
     (vendor\symfony\http-kernel\HttpKernel.php:181)
  at Symfony\Component\HttpKernel\HttpKernel->handleRaw()
     (vendor\symfony\http-kernel\HttpKernel.php:76)
  at Symfony\Component\HttpKernel\HttpKernel->handle()
     (vendor\symfony\http-kernel\Kernel.php:197)
  at Symfony\Component\HttpKernel\Kernel->handle()
     (public\index.php:42)           
```

Commits
-------

6d55c5dd Fix type error in downloads content element
9cd9c6ab allow null for listContentsFromSerialized instead
leofeyer added a commit that referenced this pull request Oct 1, 2024
Description
-----------

Implements #7271

Commits
-------

2bc43018 Update swiper.html.twig
d8d36d10 Update swiper.html.twig
c6d2885e Revert "Update swiper.html.twig"
a0ce54ad build slider_settings in controller
29ef7f7b remove asset
48ce7302 fix typo
51e767fe Merge pull request #1 from fritzmg/swiper-7470
c1364ea3 remove asset
6a2111d0 fix test
d9cdb37c update assets
516970e8 rename variable
9403040e Merge remote-tracking branch 'origin/5.x' into 7470-fix-ci
0ba3867b Merge pull request #2 from fritzmg/7470-fix-ci
63d98741 added comment with example swiper.html.twig
99909376 correcting some space swiper.html.twig
61c6e12a Update core-bundle/contao/templates/twig/content_element/swiper.html.…
30bc3556 Remove the old data attributes
0f1d9990 Fix the unit test

Co-authored-by: fritzmg <fmg@inspiredminds.at>
Co-authored-by: leofeyer <1192057+leofeyer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants