Visitar URL original
ICC fixes by eile · Pull Request #738 · cpp-netlib/cpp-netlib · GitHub
Skip to content

ICC fixes #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deanberris merged 2 commits into from
Mar 1, 2017
Merged

ICC fixes #738

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2f806f
ICC fixes (#4)
eile Mar 1, 2017
831be70
ICC fix, as suggested upstream
Mar 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
ICC fixes (#4)
  • Loading branch information
@eile
eile authored Mar 1, 2017
commit d2f806f55512431accb346d645b9803c0eea37f7
4 changes: 2 additions & 2 deletions boost/network/protocol/http/client/facade.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ class basic_client_facade {
} else {
if (boost::empty(content_type_headers)) {
typedef typename char_<Tag>::type char_type;
static char_type content_type[] = "x-application/octet-stream";
static char_type* content_type = "x-application/octet-stream";

@deanberris deanberris Mar 1, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose a better change here would be:

static char_type const content_type[] = "...";

request << header("Content-Type", content_type);
}
}
Expand Down Expand Up @@ -236,7 +236,7 @@ class basic_client_facade {
} else {
if (boost::empty(content_type_headers)) {
typedef typename char_<Tag>::type char_type;
static char_type content_type[] = "x-application/octet-stream";
static char_type* content_type = "x-application/octet-stream";
request << header("Content-Type", content_type);
}
}
Expand Down