Visitar URL original
refs #13698 - Library: avoid impossible type lookups by firewave · Pull Request #7373 · cppcheck-opensource/cppcheck · GitHub
Skip to content

refs #13698 - Library: avoid impossible type lookups - #7373

Closed
firewave wants to merge 4 commits into
cppcheck-opensource:mainfrom
firewave:lib-lookup
Closed

refs #13698 - Library: avoid impossible type lookups#7373
firewave wants to merge 4 commits into
cppcheck-opensource:mainfrom
firewave:lib-lookup

Conversation

@firewave

@firewave firewave commented Mar 13, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@firewave firewave changed the title refs #13698 - Library: avoid some lookups of empty strings refs #13698 - Library: avoid impossible type lookups Mar 13, 2025
@firewave
firewave marked this pull request as draft March 13, 2025 08:49
@firewave

firewave commented Mar 13, 2025

Copy link
Copy Markdown
Collaborator Author

Okay - this appears to be quite a mess (surprise, surprise).

The function declaration stuff has lots of other cases. And I am also seeing function calls getting through which do not seem to be recognized as such.

@firewave
firewave force-pushed the lib-lookup branch 3 times, most recently from c212dfc to 4885b2f Compare March 13, 2025 09:12
@firewave

firewave commented Mar 13, 2025

Copy link
Copy Markdown
Collaborator Author

And I am also seeing function calls getting through which do not seem to be recognized as such.

I wonder if that is a chicken/egg issue. In the --dump output it is associated with a function but in the lookup it isn't. I guess because that relation has not yet been established at that point.

Maybe those type lookups need to be deferred?

@firewave

This comment was marked as resolved.

Sign in to view
firewave
firewave commented Mar 13, 2025
View reviewed changes
Comment thread lib/library.cpp Resolved
@sonarqubecloud

sonarqubecloud Bot commented Sep 10, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@firewave firewave mentioned this pull request Sep 12, 2025
Merged
@firewave

firewave commented Sep 15, 2025

Copy link
Copy Markdown
Collaborator Author

Closing as there is not much of value left here.

@firewave firewave closed this Sep 15, 2025
@firewave
firewave deleted the lib-lookup branch September 15, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrchr-github chrchr-github chrchr-github left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@firewave @chrchr-github