Visitar URL original
Refactor tests and metadata by aaronliu0130 · Pull Request #317 · cpplint/cpplint · GitHub
Skip to content

Refactor tests and metadata #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronliu0130 merged 5 commits into from
Mar 11, 2025
Merged

Refactor tests and metadata #317

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1e31b4a
update fields of pyproject.toml
aaronliu0130 Mar 7, 2025
feb0b75
update CONTRIBUTING.rst
aaronliu0130 Mar 8, 2025
47f9a12
lint CLI tests
aaronliu0130 Feb 1, 2025
3a5eaee
fix: revert Win32 slash replacement changes, use subprocess.run()
aaronliu0130 Mar 3, 2025
218a71c
remove Python 2 keyword artifacts from pylint class-rgx
cclauss Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: revert Win32 slash replacement changes, use subprocess.run() 
Yep, I forgot the purpose of something I coded myself.

subprocess.run() is Python's recommended replacement to popen that doesn't need context management
  • Loading branch information
@aaronliu0130
aaronliu0130 committed Mar 11, 2025
commit 3a5eaeef53d02a13a0e5aa3b0d17f513e321daab
25 changes: 10 additions & 15 deletions cpplint_clitest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,24 +54,19 @@ def run_shell_command(cmd: str, args: str, cwd='.'):
args: A string with arguments to the command.
cwd: from which folder to run.
"""

stdout_target = subprocess.PIPE
stderr_target = subprocess.PIPE

with subprocess.Popen(cmd + ' ' + args,
shell=True,
cwd=cwd,
stdout=stdout_target,
stderr=stderr_target) as proc:
out, err = proc.communicate()
cmd, args = cmd.split(), args.split()
proc = subprocess.run(cmd + args, cwd=cwd, capture_output=True)
out, err = proc.stdout, proc.stderr

# Make output system-agnostic, aka support Windows
if os.sep == '\\':
args_paths = args.split(' ')
for path in args_paths:
win_path = (os.path.dirname(path) + '\\').encode()
good_path = win_path.replace(b'\\', b'/')
out, err = out.replace(win_path, good_path), err.replace(win_path, good_path)
# TODO: Support scenario with multiple input names
# We currently only support the last arguments as the input name
# to prevent accidentally replacing sed tests.
# Fixing would likely need coding an internal "replace slashes" option for cpplint itself.
win_path = (os.path.dirname(args[-1]) + '\\').encode()
good_path = win_path.replace(b'\\', b'/')
out, err = out.replace(win_path, good_path), err.replace(win_path, good_path)
if os.linesep == '\r\n':
out, err = out.replace(b'\r\n', b'\n'), err.replace(b'\r\n', b'\n')

Expand Down