Repository navigation
feat(ocm): expose received webapp metadata - #5853
Open
MahdiBaghbani wants to merge 8 commits into
Open
MahdiBaghbani wants to merge 8 commits into
MahdiBaghbani wants to merge 8 commits into
Conversation
MahdiBaghbani
requested review from
diocas,
glpatcern,
jessegeens and
rawe0
as code owners
September 29, 2026 10:23
This was referenced Sep 29, 2026
MahdiBaghbani
force-pushed
the
received-webapp-metadata-producer
branch
from
September 29, 2026 12:36
887c6ed to
70e7481
Compare
MahdiBaghbani
force-pushed
the
received-webapp-metadata-producer
branch
from
October 6, 2026 06:45
70e7481 to
9da7400
Compare
Member
Author
|
Time zone test failure, interesting! I was unable to catch this since my laptop is set in UTC, but the CERNBox runner is set to Zurich time zone, nice |
MahdiBaghbani
force-pushed
the
received-webapp-metadata-producer
branch
from
October 7, 2026 08:38
16c9d85 to
ab999e9
Compare
MahdiBaghbani
force-pushed
the
received-webapp-metadata-producer
branch
from
October 8, 2026 08:29
ab999e9 to
b53ebf3
Compare
glpatcern
force-pushed
the
received-webapp-metadata-producer
branch
3 times, most recently
from
October 12, 2026 14:26
1f54cc2 to
bb22555
Compare
MahdiBaghbani
force-pushed
the
received-webapp-metadata-producer
branch
from
October 15, 2026 16:20
ae833cc to
4aa0273
Compare
MahdiBaghbani
force-pushed
the
received-webapp-metadata-producer
branch
from
October 15, 2026 19:34
4aa0273 to
d2d6803
Compare
MahdiBaghbani
force-pushed
the
received-webapp-metadata-producer
branch
from
October 15, 2026 20:56
d2d6803 to
4112636
Compare
glpatcern
force-pushed
the
received-webapp-metadata-producer
branch
3 times, most recently
from
October 20, 2026 09:20
e576dc8 to
92c05f8
Compare
glpatcern
previously approved these changes
Oct 22, 2026
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
MahdiBaghbani
force-pushed
the
received-webapp-metadata-producer
branch
from
October 30, 2026 15:37
92c05f8 to
831d1cf
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the cs3org/OCM-STA#20 and cs3org/OCM-STA#48
Summary
WebappMetadataForReceivedSharereads the storedAppNamewhen the received share has exactly one webapp protocol, verbatim with no trim or fallback, andgetSharedWithMehands it to the carrier from refactor(ocm): add graph webapp metadata carrier #5852 for that same share.shareIdonly, and onlyappNamereaches the API:sharedSecret,appIconHint, andmediaTypesstay on the stored protocol.getSharedWithMeagainst the refactor(ocm): add graph webapp metadata carrier #5852 goldens (CodiMD, key omitted for WebDAV-only,"appName":""), and check that two shares in one response keep their own names.flowchart TD S["received OCM share"] --> W["WebappMetadataForReceivedShare(ctx, share)"] W -->|"exactly one webapp protocol"| P["Present, AppName as stored"] W -->|"none"| N["nil"] W -->|"more than one"| DUP["warn on the request logger, shareId only"] DUP --> N P --> C["newReceivedShareDriveItem"] N --> C C -->|"Present"| K["remoteItem @ocm.webApp"] C -->|"nil"| U["DriveItem JSON unchanged"]