Visitar URL original
feat(ocm): expose received webapp metadata by MahdiBaghbani · Pull Request #5853 · cs3org/reva · GitHub
Skip to content

feat(ocm): expose received webapp metadata - #5853

Open
MahdiBaghbani wants to merge 8 commits into
graph-webapp-metadata-carrierfrom
received-webapp-metadata-producer
Open

MahdiBaghbani wants to merge 8 commits into
graph-webapp-metadata-carrierfrom
received-webapp-metadata-producer

Conversation

@MahdiBaghbani

@MahdiBaghbani MahdiBaghbani commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

This PR is part of the cs3org/OCM-STA#20 and cs3org/OCM-STA#48

Summary

  • Return the received webapp name on sharedWithMe. WebappMetadataForReceivedShare reads the stored AppName when the received share has exactly one webapp protocol, verbatim with no trim or fallback, and getSharedWithMe hands it to the carrier from refactor(ocm): add graph webapp metadata carrier #5852 for that same share.
  • Leave the key out for zero webapp protocols or more than one, rather than guessing which offer applies. A duplicate is logged on the request logger with shareId only, and only appName reaches the API: sharedSecret, appIconHint, and mediaTypes stay on the stored protocol.
  • Test through getSharedWithMe against the refactor(ocm): add graph webapp metadata carrier #5852 goldens (CodiMD, key omitted for WebDAV-only, "appName":""), and check that two shares in one response keep their own names.
flowchart TD
    S["received OCM share"] --> W["WebappMetadataForReceivedShare(ctx, share)"]
    W -->|"exactly one webapp protocol"| P["Present, AppName as stored"]
    W -->|"none"| N["nil"]
    W -->|"more than one"| DUP["warn on the request logger, shareId only"]
    DUP --> N
    P --> C["newReceivedShareDriveItem"]
    N --> C
    C -->|"Present"| K["remoteItem @ocm.webApp"]
    C -->|"nil"| U["DriveItem JSON unchanged"]
Loading

@MahdiBaghbani

MahdiBaghbani commented Oct 6, 2026 •

Copy link
Copy Markdown
Member Author

Time zone test failure, interesting! I was unable to catch this since my laptop is set in UTC, but the CERNBox runner is set to Zurich time zone, nice

@MahdiBaghbani
MahdiBaghbani force-pushed the received-webapp-metadata-producer branch from 16c9d85 to ab999e9 Compare October 7, 2026 08:38
@MahdiBaghbani
MahdiBaghbani force-pushed the received-webapp-metadata-producer branch from ab999e9 to b53ebf3 Compare October 8, 2026 08:29
@glpatcern
glpatcern force-pushed the received-webapp-metadata-producer branch 3 times, most recently from 1f54cc2 to bb22555 Compare October 12, 2026 14:26
@MahdiBaghbani
MahdiBaghbani force-pushed the received-webapp-metadata-producer branch from ae833cc to 4aa0273 Compare October 15, 2026 16:20
@MahdiBaghbani
MahdiBaghbani force-pushed the received-webapp-metadata-producer branch from 4aa0273 to d2d6803 Compare October 15, 2026 19:34
@MahdiBaghbani
MahdiBaghbani force-pushed the received-webapp-metadata-producer branch from d2d6803 to 4112636 Compare October 15, 2026 20:56
@glpatcern
glpatcern force-pushed the received-webapp-metadata-producer branch 3 times, most recently from e576dc8 to 92c05f8 Compare October 20, 2026 09:20
glpatcern
glpatcern previously approved these changes Oct 22, 2026
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature OCM Open Cloud Mesh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants