Repository navigation
Conversation
|
Analysis of PR #23185 at e4999328: Test 3234 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 240 different CI jobs (the link just goes to one of them). Note that this CI job has had a number of other flaky tests recently (2, to be specific) so it may be that this failure is rather a systemic issue with this job and not with this specific PR. Generated by Testclutch |
apeschar
force-pushed
the
share-ca-cache
branch
from
September 30, 2026 12:14
e499932 to
c39ea80
Compare
apeschar
force-pushed
the
share-ca-cache
branch
from
October 1, 2026 18:01
1fe4d35 to
f4a128a
Compare
Author
|
All the test, code style issues that caused CI to fail have been fixed. Remaining failures are dependency download issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the share API does not support sharing CA stores. CA stores are automatically shared between connections on a multi handle, but cannot be shared between multi handles.
I use separate multi handles to isolate connection pools. When creating many new multi handles for SSL connections, repeated reads of the CA store add up to significant CPU load.
This PR introduces CURL_LOCK_DATA_CA to enable sharing of CA stores.