Repository navigation
Conversation
Move server fixtures for dnsd and danted into conftest.py, so they start early and port allocations have less chance to be confused. Starting them later while many other tests are running in parallel has the chance that an allocated port is picked up by a client before the server can re-grab it.
icing
force-pushed
the
pytest-server-start-early
branch
from
October 8, 2026 08:58
608ecf9 to
d07e4ac
Compare
vszakats
approved these changes
Oct 8, 2026
vszakats
left a comment
vszakats
left a comment
Member
There was a problem hiding this comment.
Nice!
If you have an example of a confused run at hand, I'd be happy to have a look, maybe it helps recognizing the pattern if it reoccurs.
Contributor
Author
|
I think we do not run
|
Contributor
Author
|
@vszakats feel like merging this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move server fixtures for dnsd and danted into conftest.py, so they start early and port allocations have less chance to be confused.
Starting them later while many other tests are running in parallel has the chance that an allocated port is picked up by a client before the server can re-grab it.