Add comprehensive test coverage for database queries and API endpoints - #25

src/pages/api/settings/index.test.ts (1)

210-232: Consider adding assertion for getUserPreferences call for consistency.

The test validates challenge_reminders updates correctly, but unlike the similar success test (lines 172-176), it doesn't assert that getUserPreferences was called after the update. This is a minor consistency gap.

♻️ Suggested addition for consistency

             expect(response.status).toBe(200)
             expect(data.success).toBe(true)
             expect(updateUserPreferences).toHaveBeenCalledWith(mockUserId, {
                 challenge_reminders: false,
             })
+            expect(getUserPreferences).toHaveBeenCalledWith(mockUserId)
         })

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/pages/api/settings/index.test.ts` around lines 210 - 232, Add the missing
assertion that verifies getUserPreferences was called after a successful update
in the test for challenge_reminders; specifically, in the it('should update
challenge_reminders when provided', ...) case assert that getUserPreferences was
called with mockUserId (the same check used in the similar success test),
placing the expect(getUserPreferences).toHaveBeenCalledWith(mockUserId) after
the POST call and before finishing the test.

src/pages/api/challenges/xp.test.ts (1)

37-41: Mock return type is missing currentLevel property.

Per the context snippet from src/lib/challenges.ts:251-270, getXPProgress() returns { currentLevel, currentLevelXP, nextLevelXP, progress }. While the current implementation doesn't use currentLevel, including it in the mock would make the test more robust against future changes and removes the need for as any.

Proposed fix

         vi.mocked(getXPProgress).mockReturnValue({
+            currentLevel: 3,
             progress: 20,
             currentLevelXP: 250,
             nextLevelXP: 500,
-        } as any)
+        })

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/pages/api/challenges/xp.test.ts` around lines 37 - 41, The mock for
getXPProgress in the test is missing the currentLevel property and uses a cast
to any; update the mock return object used in
vi.mocked(getXPProgress).mockReturnValue to include currentLevel (e.g.,
currentLevel: 1) alongside progress, currentLevelXP, and nextLevelXP so the
shape matches the real return from getXPProgress and remove the unnecessary type
coercion.

src/lib/services/loginRewardService.test.ts (1)

432-432: Mock return type should match actual function signature.

Per the context snippet from src/lib/server/db/queries.ts:861-896, awardAchievement returns Promise<boolean>. The mock should resolve to true instead of undefined.

Proposed fix

-        vi.mocked(awardAchievement).mockResolvedValue(undefined as any)
+        vi.mocked(awardAchievement).mockResolvedValue(true)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lib/services/loginRewardService.test.ts` at line 432, The test mock for
awardAchievement returns undefined but the real function signature returns
Promise<boolean>; update the mock in loginRewardService.test (the
vi.mocked(awardAchievement) call) to resolve a boolean (e.g., change
mockResolvedValue(undefined as any) to mockResolvedValue(true)) so the mocked
return type matches awardAchievement's Promise<boolean> signature and prevents
type/runtime mismatches.

src/pages/api/settings/index.test.ts (1)

15-16: Consider adding mock cleanup between tests.

The test suite doesn't reset mocks between tests. While each test explicitly sets mock return values, adding beforeEach(() => vi.clearAllMocks()) would ensure test isolation and prevent potential state leakage—particularly useful as the test suite grows.

♻️ Suggested addition after line 16

 describe('Settings API', () => {
     const mockUserId = 'test-user-123'
+
+    beforeEach(() => {
+        vi.clearAllMocks()
+    })

     const mockLocals = {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/pages/api/settings/index.test.ts` around lines 15 - 16, Add a test-level
cleanup hook to the "Settings API" suite to avoid mock state leaking: inside the
describe block that defines mockUserId, add a beforeEach that calls
vi.clearAllMocks() so all mocks are reset before each test (ensuring tests are
isolated and do not rely on prior mock call history or return values).

src/lib/server/db/queries.integration.test.ts (2)

301-321: Use raw table assertions for awardAchievement.

Lines 306-320 verify awardAchievement() through hasUserEarnedAchievement() and getUserAchievements(), which are sibling helpers from the same module. If those helpers share the same filter or mapping bug, this suite still passes. Query user_achievements directly here so the award tests keep an independent oracle.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lib/server/db/queries.integration.test.ts` around lines 301 - 321, The
tests currently validate awardAchievement('u1','tetris_master') using sibling
helpers hasUserEarnedAchievement and getUserAchievements which can mask shared
bugs; instead, after calling awardAchievement (and after seedAchievement in the
duplicate test) run a direct query against the user_achievements table to assert
the row exists and that there is only one row for user_id 'u1' and
achievement_id 'tetris_master'. Update the second test to replace the
getUserAchievements/filter assertion with a raw DB query that counts rows where
user_id = 'u1' AND achievement_id = 'tetris_master' and assert count === 1, and
in the first test assert the direct table contains the new row rather than using
hasUserEarnedAchievement.

---

123-145: Type the seedUserStats fixture shape.

Record<string, unknown> lets misspelled keys silently fall back to defaults, and v hides what the object represents. A small typed fixture interface or Partial<...> plus a descriptive name makes schema drift obvious at compile time.

As per coding guidelines, **/*.{js,ts,jsx,tsx,py,java,go}: Write clear variable names that describe their purpose; src/lib/server/**/*.ts: Use Kysely for all database queries following established patterns in src/lib/server/db/queries.ts with proper TypeScript types for entities.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lib/server/db/queries.integration.test.ts` around lines 123 - 145, The
seedUserStats helper currently accepts overrides: Record<string, unknown> and
builds an untyped object v; replace that with a properly typed fixture shape
(e.g., use Partial<UserStats> or a dedicated interface like
UserStatsInsertOverride) so TS catches misspelled keys and schema drift, rename
v to a descriptive name such as stats or seedValues, and update the INSERT call
to consume the typed fields; follow the established Kysely entity/type
definitions used in src/lib/server/db/queries.ts to import the UserStats type
and ensure the function signature and local variable types reflect that typed
shape.