Repository navigation
Run generate-clijson cleanup via .codegen.json post_generate - #6924
Open
janniklasrose wants to merge 5 commits into
Open
janniklasrose wants to merge 5 commits into
janniklasrose wants to merge 5 commits into
Conversation
Relocate the post-`genkit update-sdk` cleanup (restore .gitattributes, relocate the tagging scripts, rewrite and format tagging.yml, drop the unused next-changelog.yml, scrub internal proxy URLs from the genkit *.py.lock files) from the generate-clijson Taskfile steps into .codegen.json's toolchain.post_generate, so genkit performs it for every update-sdk caller rather than only `./task generate-clijson`. The SDK-version consistency check stays in the Taskfile for faster feedback when running generate-clijson manually. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 97d5425
Top 3 slowest tests (at least 2 minutes):
|
denik
reviewed
Oct 7, 2026
| "mv tagging.py.lock internal/genkit/tagging.py.lock", | ||
| "if [ \"$(uname)\" = \"Darwin\" ]; then sed -i '' 's|tagging.py|internal/genkit/tagging.py|g' .github/workflows/tagging.yml; else sed -i 's|tagging.py|internal/genkit/tagging.py|g' .github/workflows/tagging.yml; fi", | ||
| "if [ \"$(uname)\" = \"Darwin\" ]; then sed -i '' 's|https://pypi-proxy.cloud.databricks.com/simple/\\{0,1\\}|https://pypi.org/simple|g' internal/genkit/*.py.lock; else sed -i 's|https://pypi-proxy.cloud.databricks.com/simple/\\{0,1\\}|https://pypi.org/simple|g' internal/genkit/*.py.lock; fi", | ||
| "go tool -modfile=tools/go.mod yamlfmt .github/workflows/tagging.yml" |
Contributor
There was a problem hiding this comment.
We had it here before and moved it to Taskfile. I'd rather we keep using taskfile, because here you can reference other tasks.
Can we teach SDK auto-bumper to call task or recursively call ./task post-generate here?
Instead of running the post-`genkit update-sdk` cleanup from .codegen.json's toolchain.post_generate, keep it in the Taskfile as a dedicated generate-clijson-post task that generate-clijson references at the end. The SDK bumper can then invoke the same cleanup after its own update-sdk run. The cleanup steps (restore .gitattributes, drop next-changelog.yml, relocate the tagging scripts, rewrite and format tagging.yml, scrub internal proxy URLs from the genkit *.py.lock files) and the trailing 'ws' whitespace step all move into the new task. The SDK-version consistency check stays inline in generate-clijson for faster feedback when run manually. Co-authored-by: Isaac <no-reply@databricks.com>
…ate' into janniklasrose/codegen-post-generate
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human TL;DR: move deterministic post cli.json generation steps into
.codegen.json. Preparation for SDK auto-bumper which runsgenkitinstead oftask.Changes
Relocate the post-
genkit update-sdkcleanup forgenerate-clijsonout of theTaskfile.ymlsteps and into.codegen.json'stoolchain.post_generate:restore
.gitattributes, relocate the tagging scripts, rewrite and format.github/workflows/tagging.yml, remove the unusednext-changelog.yml, andscrub the internal PyPI-proxy URL from the genkit
*.py.lockfiles. TheSDK-version consistency check stays in the Taskfile for faster local feedback.
Why
Running the cleanup through
toolchain.post_generatemakesgenkit update-sdkperform it for every caller, not just
./task generate-clijson. An automatedSDK updater invokes genkit directly rather than through the Taskfile, so the
cleanup has to travel with the generator. Requires genkit to execute
toolchain.post_generateafter writing the generated files.Tests
Relocation only — the cleanup commands are unchanged (visible in the diff).
.codegen.jsonis valid JSON;Taskfile.ymlparses and isyamlfmt-clean.These hooks run during
genkit update-sdk(exercised locally viagenerate-clijson), which is not part of CI, so the generated-artifact checksare unaffected.
This pull request and its description were written by Isaac.