Repository navigation
Conversation
ensureDirectory only sweeps those dirs once per process, so a long-running web/server instance can fill the disk. Sweep them every 15 minutes with the existing 1-hour age policy. Fixes dbgate#1581
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensureDirectoryonly callscleanDirectorythe first time a path is touched, so a long-running web/server process never sweepsjsl/run/uploadsagain and can fill the disk (BUG: temp directories (jsl/run/uploads) are cleaned only once per process start, so a long-running server grows until the disk is full #1581).start()path that reuses the existing 1-hour mtime policy. User data infiles/archiveis not swept. Forked API workers skip the timer.ensureDirectorycall, while recent jsl files and userfiles/data stay.Test plan
yarn workspace dbgate-api test directories.cleanup.test.jsjsl/run/uploads, confirm they disappear after the next sweep without a restartfilesandarchiveare left aloneFixes #1581