Repository navigation
Conversation
|
Hi @maxdswain, thanks for your interest in contributing to Haystack! 🙏 This is an automated message to help us keep the review queue healthy. |
Coverage report (vllm)Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
|
Hi @anakin87 sorry to bother you, but have you got time to review this? I'm not sure if this has passed you/been missed. |
|
@maxdswain thank you for the ping. TBH, before implementing components supporting these capabilities, I'd prefer to investigate the overall design of multi-vector retrieval a bit, so I've opened deepset-ai/haystack#13257. Otherwise, I am afraid we will create pieces that don't work well together. |
|
Hi @anakin87 thanks for the response, I'll move this PR into draft as I'd like to contribute more PRs but can only have one open at time. In terms of multivector support, I was planning on opening PRs for Qdrant and Milvius to update the document writers, and add multivector/late-attention retrievers. It would be nice if multivector was a optional field of |
ebc55e0 to
d1ff65e
Compare
Related Issues
Proposed Changes:
VLLMMultivectorTextEmbeddercomponent to create multivector embeddings for string inputsVLLMMultivectorDocumentEmbeddercomponent to create multivector embeddings for documents.How did you test it?
Added new unit and integration tests. This included update the vLLM github workflow to include the running of a new container.
Notes for the reviewer
Wait until haystack 3.5.0 is released before merging as this PR depends on the addition of the
mutlivector_embeddingfield.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.