Visitar URL original
feat: add `VLLMMultivectorDocumentEmbedder` and `VLLMMultivectorTextEmbedder` components by maxdswain · Pull Request #4014 · deepset-ai/haystack-core-integrations · GitHub
Skip to content

feat: add VLLMMultivectorDocumentEmbedder and VLLMMultivectorTextEmbedder components - #4014

Open
maxdswain wants to merge 4 commits into
deepset-ai:mainfrom
maxdswain:vllm-multivector
Open

maxdswain wants to merge 4 commits into
deepset-ai:mainfrom
maxdswain:vllm-multivector

Conversation

@maxdswain

@maxdswain maxdswain commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Related Issues

Proposed Changes:

  • Add VLLMMultivectorTextEmbedder component to create multivector embeddings for string inputs
  • Add VLLMMultivectorDocumentEmbedder component to create multivector embeddings for documents.

How did you test it?

Added new unit and integration tests. This included update the vLLM github workflow to include the running of a new container.

Notes for the reviewer

Wait until haystack 3.5.0 is released before merging as this PR depends on the addition of the mutlivector_embedding field.

Checklist

@maxdswain
maxdswain requested a review from a team as a code owner September 28, 2026 06:21
@maxdswain
maxdswain requested review from anakin87 and removed request for a team September 28, 2026 06:21
@github-actions

Copy link
Copy Markdown
Contributor

Hi @maxdswain, thanks for your interest in contributing to Haystack! 🙏

⚠️ You currently have 3 open pull requests in this repository (#3999, #3870 and this one). Our review capacity is limited, so please hold off opening more PRs until we've had a chance to review your first 2 open PRs. This helps us give each contribution the attention it deserves. Thank you!

This is an automated message to help us keep the review queue healthy.

@github-actions github-actions Bot added topic:CI integration:vllm type:documentation Improvements or additions to documentation labels Sep 28, 2026
@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Coverage report (vllm)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  integrations/vllm/src/haystack_integrations/components/embedders/vllm
  multivector_document_embedder.py
  multivector_text_embedder.py
Project Total  

This report was generated by python-coverage-comment-action

@maxdswain

Copy link
Copy Markdown
Contributor Author

Hi @anakin87 sorry to bother you, but have you got time to review this? I'm not sure if this has passed you/been missed.

@anakin87

Copy link
Copy Markdown
Member

@maxdswain thank you for the ping.

TBH, before implementing components supporting these capabilities, I'd prefer to investigate the overall design of multi-vector retrieval a bit, so I've opened deepset-ai/haystack#13257. Otherwise, I am afraid we will create pieces that don't work well together.

@maxdswain

maxdswain commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor Author

Hi @anakin87 thanks for the response, I'll move this PR into draft as I'd like to contribute more PRs but can only have one open at time.

In terms of multivector support, I was planning on opening PRs for Qdrant and Milvius to update the document writers, and add multivector/late-attention retrievers. It would be nice if multivector was a optional field of Document similar to dense/sparse embeddings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:vllm topic:CI type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Multivector Embedding Components for vLLM Integration

2 participants