Repository navigation
Conversation
Use getCheckEvaluate in caption and no-autoplay-audio tests so existing cases verify diagnostic messages for their results, including incomplete results. Preserve the fixtures, options and assertions. Refs: dequelabs#5375
ellenbarbado642-ops
approved these changes
Oct 17, 2026
Contributor
|
Thanks for the pr. We have a lot of open prs at the moment so we'll try to get to this as soon as we can. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The caption and no-autoplay-audio tests currently call check.evaluate directly, so they still pass if an incomplete diagnostic message is missing. Route their existing cases through testutils.getCheckEvaluate with message verification enabled and explicit mock contexts.
Preserve all 17 existing cases, including incomplete results, caption's none-rule semantics, composed-tree captions, media preloading, allowed duration, looping, and controls.
Part of #5375, following the agreed split into focused migration PRs. Additional check families remain.
Validation:
The local pnpm test wrapper passed TypeScript but could not spawn the cached pnpm.cjs (EACCES). The browser suites passed using npm-run-all's supported --npm-path option pointing to the same installed pnpm 11.17.0 module. This workaround changes no project files.
Prepared with Codex. Human review pending.