Visitar URL original
Improved package command by mmhat · Pull Request #2508 · dhall-lang/dhall-haskell · GitHub
Skip to content

Improved package command - #2508

Merged
mmhat merged 4 commits into
dhall-lang:mainfrom
mmhat:improved-package-command
Apr 15, 2023
Merged

Improved package command#2508
mmhat merged 4 commits into
dhall-lang:mainfrom
mmhat:improved-package-command

Conversation

@mmhat

@mmhat mmhat commented Apr 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

You can now include files that reside below the output directory in the package. This is for example useful if you want to include sub-packages in a top-level package, i.e:

> dhall package toplevel.dhall Sub/package.dhall Other/file.dhall
{ toplevel = ./toplevel.dhall
, Sub = ./Sub/package.dhall
, Other.file = ./Other/file.dhall
}

@mmhat
Improved package command
880f363 
You can now include files that reside below the output directory in the
package. This is for example useful if you want to include sub-packages
in a top-level package.
Gabriella439
Gabriella439 approved these changes Apr 15, 2023
View reviewed changes

@Gabriella439 Gabriella439 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few tiny suggestions, but overall this looks great!

Comment thread dhall/src/Dhall/Package.hs Resolved
Comment thread dhall/src/Dhall/Package.hs Resolved
Comment thread dhall/src/Dhall/Package.hs Resolved
mmhat and others added 3 commits April 15, 2023 11:34
@mmhat @Gabriella439
Update dhall/src/Dhall/Package.hs
a9e775d 
Co-authored-by: Gabriella Gonzalez <GenuineGabriella@gmail.com>
@mmhat @Gabriella439
Update dhall/src/Dhall/Package.hs
93c7e01 
Co-authored-by: Gabriella Gonzalez <GenuineGabriella@gmail.com>
@mmhat @Gabriella439
Update dhall/src/Dhall/Package.hs
2cf982c 
Co-authored-by: Gabriella Gonzalez <GenuineGabriella@gmail.com>
@mmhat
mmhat enabled auto-merge (squash) April 15, 2023 09:35
@mmhat
mmhat merged commit 4fd1865 into dhall-lang:main Apr 15, 2023
@mmhat
mmhat deleted the improved-package-command branch September 13, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gabriella439 Gabriella439 Gabriella439 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmhat @Gabriella439