Repository navigation
fix(docker): omit inherited daemon flags from Linux config - #1425
Open
tdewanNvidia wants to merge 1 commit into
Open
tdewanNvidia wants to merge 1 commit into
tdewanNvidia wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On self-hosted Linux runners,
Install.install()copies/etc/docker/daemon.jsoninto the job's daemon configuration and also supplies--host,--data-root,--exec-root, and--pidfile. A host configuration containing any of those options makes dockerd refuse to start because the option appears both in the file and on the command line. For example, a host{"data-root":"/data/docker"}prevents rootless Docker from starting.Remove those four inherited options from the per-job copy before merging the explicitly supplied
daemonConfig. Preserve other host settings, including registry mirrors, and leave the host file unchanged. The command-line flags continue to own the isolated daemon paths. Explicit caller configuration retains its existing merge behavior.Validation:
install()API with synthetic host configuration for rootless and ordinary Linux Docker. Both fail before the fix and pass after it, checking the emitted daemon JSON and per-job data directory.yarn test __tests__/docker/install-config.test.ts: 2 passed (invoked through the installed Vitest binary).yarn lint: passed (invoked through the installed ESLint binary).yarn build: passed (invoked through the installed TypeScript compiler).git diff --check: passed.