Visitar URL original
bake: ulimits and shm-size support by crazy-max · Pull Request #2242 · docker/buildx · GitHub
Skip to content

bake: ulimits and shm-size support - #2242

Merged
tonistiigi merged 4 commits into
docker:masterfrom
crazy-max:bake-ulimits-shmsize
Feb 22, 2024
Merged

bake: ulimits and shm-size support#2242
tonistiigi merged 4 commits into
docker:masterfrom
crazy-max:bake-ulimits-shmsize

Conversation

@crazy-max

@crazy-max crazy-max commented Feb 5, 2024

Copy link
Copy Markdown
Member

fixes #2241

@crazy-max
crazy-max force-pushed the bake-ulimits-shmsize branch 6 times, most recently from 0bdee7c to 03edd08 Compare February 5, 2024 22:54
@crazy-max crazy-max mentioned this pull request Feb 8, 2024
Closed
@crazy-max crazy-max added this to the v0.13.0 milestone Feb 9, 2024
@crazy-max
crazy-max requested a review from tonistiigi February 9, 2024 09:30
@crazy-max
crazy-max marked this pull request as ready for review February 9, 2024 09:30
tonistiigi
tonistiigi reviewed Feb 9, 2024
View reviewed changes
Comment thread docs/bake-reference.md Resolved
@crazy-max
crazy-max force-pushed the bake-ulimits-shmsize branch from d11b1da to 57d2c29 Compare February 14, 2024 14:19
@crazy-max
crazy-max requested a review from tonistiigi February 14, 2024 14:19
dvdksn
dvdksn reviewed Feb 15, 2024
View reviewed changes

@dvdksn dvdksn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions / some I am not sure about so feel free to dismiss if you disagree

Comment thread docs/bake-reference.md Resolved
Comment thread docs/reference/buildx_build.md Resolved
Comment thread docs/reference/buildx_build.md Resolved
Comment thread docs/reference/buildx_build.md Resolved
Comment thread docs/reference/buildx_build.md Resolved
@crazy-max
test: fix message output
345551a 
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max
bake: shm-size support
c2befc0 
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max
bake: ulimits support
64e2b25 
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max
docs: more context around shm-size and ulimit usage
73d8969 
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max
crazy-max force-pushed the bake-ulimits-shmsize branch from 57d2c29 to 73d8969 Compare February 20, 2024 10:29
dvdksn
dvdksn approved these changes Feb 20, 2024
View reviewed changes

@dvdksn dvdksn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonistiigi
tonistiigi merged commit daaa8f2 into docker:master Feb 22, 2024
@crazy-max
crazy-max deleted the bake-ulimits-shmsize branch February 22, 2024 06:57
@crazy-max crazy-max mentioned this pull request Feb 23, 2024
Merged
@crazy-max crazy-max mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes
+1 more reviewer
@dvdksn dvdksn dvdksn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.13.0

Development

Successfully merging this pull request may close these issues.

buildx bake file doesn't support new ulimit directives

3 participants

@crazy-max @tonistiigi @dvdksn