Visitar URL original
Fix incorrect character encoding in SdlKeyboard by roeyskoe · Pull Request #638 · dotnet/Silk.NET · GitHub
Skip to content

Fix incorrect character encoding in SdlKeyboard - #638

Merged
Perksey merged 5 commits into
dotnet:mainfrom
roeyskoe:SdlKeyChar
Oct 14, 2021
Merged

Fix incorrect character encoding in SdlKeyboard#638
Perksey merged 5 commits into
dotnet:mainfrom
roeyskoe:SdlKeyChar

Conversation

@roeyskoe

@roeyskoe roeyskoe commented Oct 14, 2021

Copy link
Copy Markdown
Contributor

Summary of the PR

Characters were incorrectly decoded as ASCII in Sdl's TextInput. Fixed by decoding them as UTF8.

Related issues, Discord discussions, or proposals

https://discord.com/channels/521092042781229087/607634593201520651/896375164600721418

@roeyskoe
roeyskoe requested a review from Perksey as a code owner October 14, 2021 09:03
Perksey
Perksey requested changes Oct 14, 2021
View reviewed changes
Comment thread src/Input/Silk.NET.Input.Sdl/SdlKeyboard.cs Resolved
Comment thread src/Input/Silk.NET.Input.Sdl/SdlKeyboard.cs Resolved
Comment thread src/Input/Silk.NET.Input.Sdl/SdlKeyboard.cs Resolved
Comment thread src/Input/Silk.NET.Input.Sdl/SdlKeyboard.cs Resolved
Perksey
Perksey reviewed Oct 14, 2021
View reviewed changes
Comment thread src/Input/Silk.NET.Input.Sdl/SdlKeyboard.cs Resolved
@Perksey
Perksey enabled auto-merge (squash) October 14, 2021 09:28
auto-merge was automatically disabled October 14, 2021 09:29

Head branch was pushed to by a user without write access

@Perksey
Perksey self-requested a review October 14, 2021 12:06
Perksey
Perksey reviewed Oct 14, 2021
View reviewed changes
Comment thread src/Input/Silk.NET.Input.Sdl/SdlKeyboard.cs Resolved
@Perksey
Perksey enabled auto-merge (squash) October 14, 2021 12:09
@Perksey
Perksey merged commit f25648d into dotnet:main Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Perksey Perksey Perksey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roeyskoe @Perksey