Visitar URL original
Release notes v4.0.0 by johnnypham · Pull Request #1389 · dotnet/SqlClient · GitHub
Skip to content

Release notes v4.0.0 - #1389

Merged
johnnypham merged 12 commits into
dotnet:mainfrom
johnnypham:releasenotes4.0
Nov 19, 2021
Merged

Release notes v4.0.0#1389
johnnypham merged 12 commits into
dotnet:mainfrom
johnnypham:releasenotes4.0

Conversation

@johnnypham

@johnnypham johnnypham commented Nov 17, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@johnnypham johnnypham added this to the 4.0.0 milestone Nov 17, 2021
JRahnama
JRahnama reviewed Nov 17, 2021
View reviewed changes
Comment thread release-notes/4.0/4.0.0.md Resolved
JRahnama
JRahnama reviewed Nov 17, 2021
View reviewed changes
Comment thread release-notes/4.0/4.0.0.md Resolved
Comment thread release-notes/4.0/4.0.0.md Resolved
@cheenamalhotra

cheenamalhotra commented Nov 17, 2021

Copy link
Copy Markdown
Member

I think you also need to update Changelog.md with changes summarized between preview3 and now. Also include the same in Release notes (check old GA release notes for reference).

@johnnypham

johnnypham commented Nov 17, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I think you also need to update Changelog.md with changes summarized between preview3 and now. Also include the same in Release notes (check old GA release notes for reference).

I don't think there were any changes that needed to be included. However, once the new version of SNI is released, I can add that and #1378.

Edit: added the changes.

David-Engel
David-Engel reviewed Nov 18, 2021
View reviewed changes
Comment thread release-notes/4.0/4.0.0.md Resolved
Comment thread release-notes/4.0/4.0.0.md Resolved
Johnny Pham and others added 3 commits November 18, 2021 12:03
Johnny Pham @David-Engel
Update release-notes/4.0/4.0.0.md
24a7698 
Co-authored-by: David Engel <dengel1012@gmail.com>
Johnny Pham @David-Engel
Update release-notes/4.0/4.0.0.md
2704035 
Co-authored-by: David Engel <dengel1012@gmail.com>
Johnny Pham
add changes
c83d52e
DavoudEshtehari
DavoudEshtehari approved these changes Nov 18, 2021
View reviewed changes
Comment thread release-notes/4.0/4.0.0.md Resolved
Johnny Pham @DavoudEshtehari
Update release-notes/4.0/4.0.0.md
bd173cc 
Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
@johnnypham
johnnypham merged commit 768b58b into dotnet:main Nov 19, 2021
@johnnypham
johnnypham deleted the releasenotes4.0 branch November 19, 2021 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@David-Engel David-Engel David-Engel approved these changes
@Kaur-Parminder Kaur-Parminder Awaiting requested review from Kaur-Parminder
+2 more reviewers
@JRahnama JRahnama JRahnama approved these changes
@DavoudEshtehari DavoudEshtehari DavoudEshtehari approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@johnnypham @cheenamalhotra @David-Engel @JRahnama @DavoudEshtehari